Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update input warning #1870

Merged
merged 17 commits into from
Jan 18, 2024
Merged

fix: update input warning #1870

merged 17 commits into from
Jan 18, 2024

Commits on Jan 17, 2024

  1. fix: update input warning

    jackton1 committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    aacdc82 View commit details
    Browse the repository at this point in the history
  2. Update utils.ts

    jackton1 committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    db20d41 View commit details
    Browse the repository at this point in the history
  3. Apply suggestions from code review

    Co-authored-by: tj-actions[bot] <109116665+tj-actions-bot@users.noreply.github.com>
    jackton1 and tj-actions-bot committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    c28eedd View commit details
    Browse the repository at this point in the history
  4. Update utils.ts

    jackton1 committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    375be20 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    79b060d View commit details
    Browse the repository at this point in the history
  6. refactor: refactor action inputs to use default settings

    - Addition of `ACTION_INPUT_DEFAULTS` object in `constant.ts` including default settings.
    - Made changes in `utils.ts` replacing `actionInputs` references with the newly added `ACTION_INPUT_DEFAULTS`.
    jackton1 committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    8a8e4b7 View commit details
    Browse the repository at this point in the history
  7. refactor: refactor REST API input handling in utils and constants

    - Removed imports for the `fs` module and `path` from the `utils.test.ts` file
    - Deleted the `actionPath` argument from the `warnUnsupportedRESTAPIInputs` function in `utils.test.ts`
    - All tests related to YAML errors in the action file have been removed from `utils.test.ts`
    - Removed the `UNSUPPORTED_REST_API_INPUTS` constant from the `constant.ts` file and replaced it with a `Partial` type within the `UNSUPPORTED_REST_API_INPUTS` export
    - The file `utils.ts` has been updated to reflect the changes in `constant.ts`. It now iterates over `Object.keys(UNSUPPORTED_REST_API_INPUTS)`, substitutes `UNSUPPORTED_REST_API_INPUTS` for `ACTION_INPUT_DEFAULTS`, and uses type casting in condition checking.
    jackton1 committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    59d9755 View commit details
    Browse the repository at this point in the history
  8. Merge 59d9755 into 79b060d

    jackton1 committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    1839724 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    c2907d5 View commit details
    Browse the repository at this point in the history
  10. Update multi-job-test.yml

    jackton1 committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    89fe46d View commit details
    Browse the repository at this point in the history
  11. refactor: refactor GitHub actions and API handling

    - Remove the conditional checking for `GITHUB_ACTION_PATH` before calling `warnUnsupportedRESTAPIInputs`
    - Change in procedure for getting changed files from the REST API.
    jackton1 committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    b8d749c View commit details
    Browse the repository at this point in the history
  12. Merge b8d749c into 79b060d

    jackton1 committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    6f76336 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    78bbe66 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. refactor: refactor key referencing in warnUnsupportedRESTAPIInputs

    …function
    
    - Change the way key is referenced in the `warnUnsupportedRESTAPIInputs` function in `utils.ts` to use `snakeCase` only at the point of warning message generation.
    jackton1 committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    08316e3 View commit details
    Browse the repository at this point in the history
  2. Merge 08316e3 into 79b060d

    jackton1 committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    990ef65 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    16ab734 View commit details
    Browse the repository at this point in the history
  4. ci: "Refactor testing workflow and improve assertions"

    - Remove the `sha` parameter from the `.github/workflows/multi-job-test.yml` file
    - Add an expectation to check if `coreWarningSpy` is called once in `utils.test.ts`
    jackton1 committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    19bdaea View commit details
    Browse the repository at this point in the history