Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: changed_keys and modified_keys output to handle json and escape_json inputs #1585

Merged
merged 8 commits into from Sep 19, 2023
Merged

fix: changed_keys and modified_keys output to handle json and escape_json inputs #1585

merged 8 commits into from Sep 19, 2023

Conversation

V0lantis
Copy link
Contributor

@V0lantis V0lantis commented Sep 19, 2023 •
edited

Even though the new feature is almost fine, I added an update which makes it perfect in our use case.

github-actions[bot]
github-actions bot reviewed Sep 19, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing a fix, could you ensure that the test covers your changes if applicable.

@jackton1 jackton1 changed the title FEAT: Improve changedKeys and modifiedKeys output fix: changed_keys and modified_keys output to handle json and should_escape inputs Sep 19, 2023
@jackton1 jackton1 changed the title fix: changed_keys and modified_keys output to handle json and should_escape inputs fix: changed_keys and modified_keys output to handle json and escape_json inputs Sep 19, 2023
@jackton1
Copy link
Member

jackton1 commented Sep 19, 2023 •
edited

@all-contributors please add @V0lantis for bug

@allcontributors allcontributors bot mentioned this pull request Sep 19, 2023
Merged
@allcontributors
Copy link
Contributor

@jackton1

I've put up a pull request to add @V0lantis! 🎉

@jackton1
Copy link
Member

@all-contributors please add @V0lantis for code

@allcontributors
Copy link
Contributor

@jackton1

I've updated the pull request to add @V0lantis! 🎉

@V0lantis
Copy link
Contributor Author

Thanks @jackton1, hope my Pull request will help you :)

@jackton1 jackton1 added the merge when passing Merge the PR automatically once all status checks have passed label Sep 19, 2023
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@repo-ranger repo-ranger bot merged commit 951140b into tj-actions:main Sep 19, 2023
108 checks passed
szinn pushed a commit to szinn/k8s-homelab that referenced this pull request Sep 20, 2023
@repo-jeeves
fix(github-action): update tj-actions/changed-files action to v39.1.1 (…
e3bf19c 
…#2416)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[tj-actions/changed-files](https://togithub.com/tj-actions/changed-files)
| action | patch | `v39.1.0` -> `v39.1.1` |

---

### Release Notes

<details>
<summary>tj-actions/changed-files (tj-actions/changed-files)</summary>

###
[`v39.1.1`](https://togithub.com/tj-actions/changed-files/releases/tag/v39.1.1)

[Compare
Source](https://togithub.com/tj-actions/changed-files/compare/v39.1.0...v39.1.1)

#### What's Changed

- Upgraded to v39.1.0 by
[@&#8203;tj-actions-bot](https://togithub.com/tj-actions-bot) in
[tj-actions/changed-files#1583
- chore: move variable declaration by
[@&#8203;jackton1](https://togithub.com/jackton1) in
[tj-actions/changed-files#1584
- chore: Update test.yml by
[@&#8203;jackton1](https://togithub.com/jackton1) in
[tj-actions/changed-files#1586
- docs: add V0lantis as a contributor for bug by
[@&#8203;allcontributors](https://togithub.com/allcontributors) in
[tj-actions/changed-files#1587
- Updated README.md by
[@&#8203;tj-actions-bot](https://togithub.com/tj-actions-bot) in
[tj-actions/changed-files#1588
- fix: error with test by
[@&#8203;jackton1](https://togithub.com/jackton1) in
[tj-actions/changed-files#1589
- fix: changed_keys and modified_keys output to handle json and
escape_json inputs by [@&#8203;V0lantis](https://togithub.com/V0lantis)
in
[tj-actions/changed-files#1585
- chore: add codacy config by
[@&#8203;jackton1](https://togithub.com/jackton1) in
[tj-actions/changed-files#1590

#### New Contributors

- [@&#8203;V0lantis](https://togithub.com/V0lantis) made their first
contribution in
[tj-actions/changed-files#1585

**Full Changelog**:
tj-actions/changed-files@v39...v39.1.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi45Ny4zIiwidXBkYXRlZEluVmVyIjoiMzYuOTcuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: repo-jeeves <106431701+repo-jeeves[bot]@users.noreply.github.com>
Yash-Garg pushed a commit to Yash-Garg/qBittorrent-Manager that referenced this pull request Sep 20, 2023
@renovate
chore(deps): update tj-actions/changed-files action to v39.1.1 (#367)
9711280 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[tj-actions/changed-files](https://togithub.com/tj-actions/changed-files)
| action | minor | `v39.0.3` -> `v39.1.1` |

---

### Release Notes

<details>
<summary>tj-actions/changed-files (tj-actions/changed-files)</summary>

###
[`v39.1.1`](https://togithub.com/tj-actions/changed-files/releases/tag/v39.1.1)

[Compare
Source](https://togithub.com/tj-actions/changed-files/compare/v39.1.0...v39.1.1)

#### What's Changed

- Upgraded to v39.1.0 by
[@&#8203;tj-actions-bot](https://togithub.com/tj-actions-bot) in
[tj-actions/changed-files#1583
- chore: move variable declaration by
[@&#8203;jackton1](https://togithub.com/jackton1) in
[tj-actions/changed-files#1584
- chore: Update test.yml by
[@&#8203;jackton1](https://togithub.com/jackton1) in
[tj-actions/changed-files#1586
- docs: add V0lantis as a contributor for bug by
[@&#8203;allcontributors](https://togithub.com/allcontributors) in
[tj-actions/changed-files#1587
- Updated README.md by
[@&#8203;tj-actions-bot](https://togithub.com/tj-actions-bot) in
[tj-actions/changed-files#1588
- fix: error with test by
[@&#8203;jackton1](https://togithub.com/jackton1) in
[tj-actions/changed-files#1589
- fix: changed_keys and modified_keys output to handle json and
escape_json inputs by [@&#8203;V0lantis](https://togithub.com/V0lantis)
in
[tj-actions/changed-files#1585
- chore: add codacy config by
[@&#8203;jackton1](https://togithub.com/jackton1) in
[tj-actions/changed-files#1590

#### New Contributors

- [@&#8203;V0lantis](https://togithub.com/V0lantis) made their first
contribution in
[tj-actions/changed-files#1585

**Full Changelog**:
tj-actions/changed-files@v39...v39.1.1

###
[`v39.1.0`](https://togithub.com/tj-actions/changed-files/releases/tag/v39.1.0)

[Compare
Source](https://togithub.com/tj-actions/changed-files/compare/v39.0.3...v39.1.0)

##### What's Changed

- Upgraded to v39.0.3 by
[@&#8203;tj-actions-bot](https://togithub.com/tj-actions-bot) in
[tj-actions/changed-files#1577
- chore(deps): lock file maintenance by
[@&#8203;renovate](https://togithub.com/renovate) in
[tj-actions/changed-files#1578
- chore(deps): update typescript-eslint monorepo to v6.7.2 by
[@&#8203;renovate](https://togithub.com/renovate) in
[tj-actions/changed-files#1580
- feat: add support for returning YAML keys for paths that have changed
by [@&#8203;jackton1](https://togithub.com/jackton1) in
[tj-actions/changed-files#1581
- Updated README.md by
[@&#8203;tj-actions-bot](https://togithub.com/tj-actions-bot) in
[tj-actions/changed-files#1582

**Full Changelog**:
tj-actions/changed-files@v39...v39.1.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/Yash-Garg/qBittorrent-Manager).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44My4wIiwidXBkYXRlZEluVmVyIjoiMzYuOTcuMSIsInRhcmdldEJyYW5jaCI6ImRldmVsb3AifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate renovate bot mentioned this pull request Oct 6, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

Assignees
No one assigned
Labels
merge when passing Merge the PR automatically once all status checks have passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@V0lantis @jackton1