Add blink-pattern functionality to Atm_led #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bump. I like this. |
|
@tinkerspy bump |
rawtaz
reviewed
Nov 25, 2019
| @@ -1,6 +1,6 @@ | |||
| #include "Atm_led.hpp" | |||
|
|
|||
| Atm_led& Atm_led::begin( int attached_pin, bool activeLow ) { | |||
| Atm_led& Atm_led::begin( int attached_pin, bool activeLow, byte* blinkPattern, int blinkPatternSize ) { | |||
There was a problem hiding this comment.
Won't this require that one supply the third and fourth argument? What about adding another method with this, so people who don't want to use the blink pattern can do so like before?
|
I would prefer this functionality to be in a separate library and not in the standard Atm_led machine perhaps under the name Atm_led_pattern. We could put it under contributed in the Wiki. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows an LED object to blink in a pattern specified in a byte array. Each element in the array is a multiplier for the on time. I wanted this so I can chain up blinked error codes.
Also, resetting the counter when state() == OFF seems useful for any kind of repeat, not just patterns.