Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix monorepo compability #174

Merged
merged 3 commits into from
Mar 14, 2025

Conversation

timo-reymann
Copy link
Contributor

I added a test fixture & dev dependency as well for testing integration with techdocs-core.

This fixes #173

Updated uv lock

Please note that the lock file was created with uv 0.5.13, if I should use a different version, please let me know, and I will adjust it accordingly.

Change to monorepo check

In addition to making sure the monorepo plugin is present:

  • check plugin has merger attribute
  • check if merger attribute is set

This should make sure the plugin remains stable regardless of what the upstream plugin changes structurally.

timo-reymann and others added 3 commits March 14, 2025 12:09

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@timvink
Copy link
Owner

timvink commented Mar 14, 2025

Thanks! unit tests are failing for windows, always fun :)

 +  where 1 = <Result PermissionError(13, 'Permission denied')>.exit_code

I looked into this earlier, and I think it's an issue with monorepo.. I will add a pytest.mark.skip()

@timvink timvink merged commit fbd3e56 into timvink:master Mar 14, 2025
10 of 15 checks passed
@timo-reymann timo-reymann deleted the fix/monorepo-compability branch March 14, 2025 12:17
@timo-reymann
Copy link
Contributor Author

Jep tested on macOS; there everything was fine 😅

Windows is always my favorite for tests! /s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4.1.1+ breaks when used with techdocs-core
2 participants