Stream scanning #26
Open
Stream scanning #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Henderson <tadh@google.com>
Signed-off-by: Tim Henderson <tadh@google.com>
Signed-off-by: Tim Henderson <tadh@google.com>
Signed-off-by: Tim Henderson <tadh@google.com>
Signed-off-by: Tim Henderson <tadh@google.com>
Signed-off-by: Tim Henderson <tadh@google.com>
Not being able to call Peek(0) was a real pain and made using streams much more difficult. This changes the behavior of streams to make Peek(0) be ok but Peek() can only be called after Advance(>=1). Signed-off-by: Tim Henderson <tadh@google.com>
Signed-off-by: Tim Henderson <tadh@google.com>
Signed-off-by: Tim Henderson <tadh@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add support for scanning a byte stream instead of needing to read in the entire file. Note, because of how lexical analysis lookahead works in rare cases you still might need to read in the whole file. However, this will help many common cases.
This is not finished.