Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Update usage of Token model in security docs #9313

Merged

Conversation

piotrszacilowski
Copy link
Contributor

In the documentation regarding security in the code were created Token model, while it was not used. I have fixed it.

@github-actions
Copy link
Contributor

📝 Docs preview for commit 443adb8 at: https://641f65a47164c01300f564f8--fastapi.netlify.app

@piotrszacilowski
Copy link
Contributor Author

anyone willing to review?

@tiangolo tiangolo added the docs Documentation about how to use FastAPI label Oct 2, 2023
@alejsdev alejsdev changed the title Fix usage of Token model in security docs 📝 Update usage of Token model in security docs Jan 11, 2024
@tiangolo
Copy link
Owner

📝 Docs preview for commit 4cd6cc9 at: https://fdcbc765.fastapitiangolo.pages.dev

@alejsdev
Copy link
Collaborator

Thanks for your help! @piotrszacilowski 🙂

The Token was actually used in the response_model but indeed it was better to return an instance of it.

I also updated the response model to use the Token as a return type and updated the highlighted lines in the docs.

Thanks 😸

@alejsdev alejsdev merged commit fd97e8e into tiangolo:master Jan 11, 2024
39 checks passed
nilslindemann added a commit to nilslindemann/fastapi that referenced this pull request Jan 13, 2024
nilslindemann added a commit to nilslindemann/fastapi that referenced this pull request Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation about how to use FastAPI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants