Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✏ Fix typo in docs/en/docs/tutorial/query-params-str-validations.md #9272

Merged
merged 2 commits into from
Apr 13, 2023
Merged

✏ Fix typo in docs/en/docs/tutorial/query-params-str-validations.md #9272

merged 2 commits into from
Apr 13, 2023

Conversation

nicornk
Copy link
Contributor

@nicornk nicornk commented Mar 18, 2023

No description provided.

@github-actions
Copy link
Contributor

📝 Docs preview for commit 8aa502d at: https://641634a57aee3b31278bb90a--fastapi.netlify.app

@Viicos
Copy link

Viicos commented Mar 19, 2023

@nicornk While you are on this one there's a missing comma here:

https://github.com/tiangolo/fastapi/blame/master/docs/en/docs/tutorial/query-params-str-validations.md#L201-L203 🙏

@Viicos Viicos mentioned this pull request Apr 12, 2023
Merged
@github-actions
Copy link
Contributor

📝 Docs preview for commit 3f996d5 at: https://6437bb720ac3ce7160ff837f--fastapi.netlify.app

@nicornk
Copy link
Contributor Author

nicornk commented Apr 13, 2023

@r0b2g1t Who is merging here?

@r0b2g1t
Copy link

r0b2g1t commented Apr 13, 2023

@r0b2g1t Who is merging here?

Someone with write access to the repo. I don't have the permissions.

@Viicos
Copy link

Viicos commented Apr 13, 2023

@r0b2g1t Who is merging here?

Someone with write access to the repo. I don't have the permissions.

I think he meant which PR is going to be merged, as one is a duplicate of the other.

@tiangolo tiangolo changed the title Fix typo in query-params-str-validations.md ✏ Fix typo in docs/en/docs/tutorial/query-params-str-validations.md Apr 13, 2023
@tiangolo
Copy link
Owner

Thank you @nicornk! ☕

I just had merged #9380 solving the same problem because I hadn't seen you had made this PR first. I'm still gonna merge it even though it's fixed already just to get your name there. 🤓🍰

@tiangolo tiangolo merged commit c21e337 into tiangolo:master Apr 13, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ryandaydev Ryandaydev Ryandaydev approved these changes

@r0b2g1t r0b2g1t r0b2g1t approved these changes

@Kludex Kludex Kludex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nicornk @Viicos @r0b2g1t @tiangolo @Ryandaydev @Kludex