Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 Add Korean translation for docs/tutorial/dependencies/classes-as-dependencies.md #9176

Merged
merged 19 commits into from
Apr 13, 2023
Merged

🌐 Add Korean translation for docs/tutorial/dependencies/classes-as-dependencies.md #9176

merged 19 commits into from
Apr 13, 2023

Conversation

sehwan505
Copy link
Contributor

@sehwan505 sehwan505 commented Mar 3, 2023 •
edited

  • Add Korean translation for docs/ko/docs/tutorial/dependencies/classes-as-dependencies.md
  • this is my first contribute, I'm always waiting for your feedback @joonas-yoon @hard-coders @NinaHwang

@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023

📝 Docs preview for commit 425d3e9 at: https://6402022ffb679c24d096af5e--fastapi.netlify.app

@tiangolo tiangolo added lang-all Translations awaiting-review lang-ko Korean translations and removed awaiting-review labels Mar 4, 2023
NinaHwang
NinaHwang reviewed Apr 5, 2023
View reviewed changes
Copy link
Contributor

@NinaHwang NinaHwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @sehwan505 !
Sorry that i was late. Overall it looks great, still I suggest a few changes.
Please review them 🚀

docs/ko/docs/tutorial/dependencies/classes-as-dependencies.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/dependencies/classes-as-dependencies.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/dependencies/classes-as-dependencies.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/dependencies/classes-as-dependencies.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/dependencies/classes-as-dependencies.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/dependencies/classes-as-dependencies.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/dependencies/classes-as-dependencies.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/dependencies/classes-as-dependencies.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/dependencies/classes-as-dependencies.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/dependencies/classes-as-dependencies.md Outdated Show resolved Hide resolved
sehwan505 and others added 15 commits April 5, 2023 21:53
@sehwan505 @NinaHwang
Update docs/ko/docs/tutorial/dependencies/classes-as-dependencies.md
5e936ce 
Co-authored-by: Nina Hwang <79563565+NinaHwang@users.noreply.github.com>
@sehwan505 @NinaHwang
Update docs/ko/docs/tutorial/dependencies/classes-as-dependencies.md
8635580 
Co-authored-by: Nina Hwang <79563565+NinaHwang@users.noreply.github.com>
@sehwan505 @NinaHwang
Update docs/ko/docs/tutorial/dependencies/classes-as-dependencies.md
f771f7c 
Co-authored-by: Nina Hwang <79563565+NinaHwang@users.noreply.github.com>
@sehwan505 @NinaHwang
Update docs/ko/docs/tutorial/dependencies/classes-as-dependencies.md
0f0a96f 
Co-authored-by: Nina Hwang <79563565+NinaHwang@users.noreply.github.com>
@sehwan505 @NinaHwang
Update docs/ko/docs/tutorial/dependencies/classes-as-dependencies.md
103efcf 
Co-authored-by: Nina Hwang <79563565+NinaHwang@users.noreply.github.com>
@sehwan505 @NinaHwang
Update docs/ko/docs/tutorial/dependencies/classes-as-dependencies.md
c2fa0e2 
Co-authored-by: Nina Hwang <79563565+NinaHwang@users.noreply.github.com>
@sehwan505 @NinaHwang
Update docs/ko/docs/tutorial/dependencies/classes-as-dependencies.md
d94326f 
Co-authored-by: Nina Hwang <79563565+NinaHwang@users.noreply.github.com>
@sehwan505 @NinaHwang
Update docs/ko/docs/tutorial/dependencies/classes-as-dependencies.md
c3318ba 
Co-authored-by: Nina Hwang <79563565+NinaHwang@users.noreply.github.com>
@sehwan505 @NinaHwang
Update docs/ko/docs/tutorial/dependencies/classes-as-dependencies.md
9107656 
Co-authored-by: Nina Hwang <79563565+NinaHwang@users.noreply.github.com>
@sehwan505 @NinaHwang
Update docs/ko/docs/tutorial/dependencies/classes-as-dependencies.md
71580de 
Co-authored-by: Nina Hwang <79563565+NinaHwang@users.noreply.github.com>
@sehwan505 @NinaHwang
Update docs/ko/docs/tutorial/dependencies/classes-as-dependencies.md
ba06a0c 
Co-authored-by: Nina Hwang <79563565+NinaHwang@users.noreply.github.com>
@sehwan505 @NinaHwang
Update docs/ko/docs/tutorial/dependencies/classes-as-dependencies.md
56122ba 
Co-authored-by: Nina Hwang <79563565+NinaHwang@users.noreply.github.com>
@sehwan505 @NinaHwang
Update docs/ko/docs/tutorial/dependencies/classes-as-dependencies.md
92cdd60 
Co-authored-by: Nina Hwang <79563565+NinaHwang@users.noreply.github.com>
@sehwan505 @NinaHwang
Update docs/ko/docs/tutorial/dependencies/classes-as-dependencies.md
be76e5f 
Co-authored-by: Nina Hwang <79563565+NinaHwang@users.noreply.github.com>
@sehwan505 @NinaHwang
Update docs/ko/docs/tutorial/dependencies/classes-as-dependencies.md
953f091 
Co-authored-by: Nina Hwang <79563565+NinaHwang@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023

📝 Docs preview for commit 953f091 at: https://642d72ac2ababf2f46d38025--fastapi.netlify.app

NinaHwang
NinaHwang approved these changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@NinaHwang NinaHwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

hard-coders
hard-coders approved these changes Apr 6, 2023
View reviewed changes
Copy link
Sponsor Contributor

@hard-coders hard-coders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late 🙇🏻‍♂️
And thanks @NinaHwang, for the review.

It looks perfect 🚀

joonas-yoon
joonas-yoon reviewed Apr 8, 2023
View reviewed changes
Copy link
Contributor

@joonas-yoon joonas-yoon left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your great work!

I got some minor comments. except them, looks good enough =D

docs/ko/docs/tutorial/dependencies/classes-as-dependencies.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/dependencies/classes-as-dependencies.md Show resolved Hide resolved
docs/ko/docs/tutorial/dependencies/classes-as-dependencies.md

<!-- <img src="/img/tutorial/dependencies/image02.png"> -->

## 코드 단축
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shortcut 을 코드 단축으로 잘 번역해주셨네요. 저는 "줄여서" 정도로 번역하면 어떨 지 한번 제안해봅니다 :)

이 세션의 내용이 단축보다는 생략의 의미가 가까워보여서요.

참고로 다른 문서에서는 shortcut to -를 -하는 쉬운 방법 으로 번역해주신 케이스가 있더라구요.

Copy link
Contributor Author

@sehwan505 sehwan505 Apr 8, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 감사합니다. 저는 제목으로는 간단한 단어를 제공하는 게 좋을 것 같아서 위와 같이 적었습니다. 일단은 기조를 유지하되 차후에 이해에 어려움을 겪는 분이 있으시다면 바로 수정해보겠습니다.

@sehwan505 @joonas-yoon
Update docs/ko/docs/tutorial/dependencies/classes-as-dependencies.md
f91eb07 
Co-authored-by: Joona Yoon <joonas-yoon@users.noreply.github.com>
@tiangolo tiangolo changed the title 🌐 Add Korean translation for docs/tutorial/dependencies/classes-as-dependencies.md 🌐 Add Korean translation for docs/tutorial/dependencies/classes-as-dependencies.md Apr 13, 2023
@tiangolo
Copy link
Owner

Thanks for your contribution @sehwan505! 🍪

And thanks for the reviews @joonas-yoon, @hard-coders, and @NinaHwang. 🤗 ☕

@tiangolo tiangolo merged commit 48afd32 into tiangolo:master Apr 13, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joonas-yoon joonas-yoon joonas-yoon approved these changes

@hard-coders hard-coders hard-coders approved these changes

@NinaHwang NinaHwang NinaHwang approved these changes

Assignees
No one assigned
Labels
approved-2 lang-all Translations lang-ko Korean translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sehwan505 @tiangolo @joonas-yoon @hard-coders @NinaHwang