♻ Remove media_type from ORJSONResponse as it's inherited from the parent class
#5805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📝 Docs preview for commit fd6a964 at: https://63a1cc57b5043502d778a687--fastapi.netlify.app |
yezz123
approved these changes
Dec 21, 2022
nzig
approved these changes
Dec 21, 2022
nurettn
approved these changes
Jan 3, 2023
tiangolo
changed the title
media_type from ORJSONResponsemedia_type from ORJSONResponse as it's inherited from the parent class
|
Yep, nice, thanks @Kludex! 🚀 And thanks everyone for the reviews ☕ |
|
📝 Docs preview for commit 1523655 at: https://6484ac8eb6fff37f3e2efd9b--fastapi.netlify.app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just noticed... Since
UJSONResponsealso doesn't have it explicitly, I've removed fromORJSONResponse.Ref.: https://github.com/encode/starlette/blob/d7558515020f4c0a96b199880c181a40678b18d5/starlette/responses.py#L182