Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 Add Korean translation for /docs/ko/docs/tutorial/schema-extra-example.md #11121

Merged
merged 5 commits into from Feb 9, 2024

Conversation

KaniKim
Copy link
Contributor

@KaniKim KaniKim commented Feb 9, 2024

  • Add Korean translation for /docs/ko/docs/tutorial/schema-extra-example.md

@KaniKim KaniKim changed the title 🌐 Add Korean translation for /docs/ko/docs/tutorial/schema-extras-example.md 🌐 Add Korean translation for /docs/ko/docs/tutorial/schema-extra-example.md Feb 9, 2024
@tiangolo
Copy link
Owner

tiangolo commented Feb 9, 2024

📝 Docs preview for commit ebfb642 at: https://c71f2ae7.fastapitiangolo.pages.dev

docs/ko/docs/tutorial/schema-extra-example.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/schema-extra-example.md Outdated Show resolved Hide resolved
docs/ko/docs/tutorial/schema-extra-example.md Outdated Show resolved Hide resolved
@KaniKim
Copy link
Contributor Author

KaniKim commented Feb 9, 2024

Thanks to @riroan for your suggestions, I changed it.

@tiangolo
Copy link
Owner

tiangolo commented Feb 9, 2024

📝 Docs preview for commit 7812818 at: https://80b9dfde.fastapitiangolo.pages.dev

Copy link
Contributor

@riroan riroan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alejsdev alejsdev added lang-all Translations awaiting-review lang-ko Korean translations labels Feb 9, 2024
@alejsdev alejsdev merged commit 383870a into tiangolo:master Feb 9, 2024
50 checks passed
@alejsdev
Copy link
Collaborator

alejsdev commented Feb 9, 2024

Great! Thanks @KaniKim 🚀✨

And thanks for the review @riroan 🤓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-1 lang-all Translations lang-ko Korean translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants