Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✏️ Remove broken links from external_links.yml #10943

Merged
merged 1 commit into from Jan 12, 2024

Conversation

Torabek
Copy link
Contributor

@Torabek Torabek commented Jan 12, 2024

A little bit of clean-up of external articles

Copy link
Contributor

@hasansezertasan hasansezertasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tiangolo
Copy link
Owner

📝 Docs preview for commit ef94d6c at: https://52ec2de8.fastapitiangolo.pages.dev

@Kludex
Copy link
Sponsor Collaborator

Kludex commented Jan 12, 2024

@tiangolo I did this some years ago for Awesome FastAPI: https://github.com/mjhea0/awesome-fastapi/blob/main/.github/workflows/expired-links.yml

Detects 404 links on MkDocs.

@tiangolo tiangolo added the docs Documentation about how to use FastAPI label Jan 12, 2024
@tiangolo tiangolo changed the title Remove broken links from external_links.yml ✏️ Remove broken links from external_links.yml Jan 12, 2024
@tiangolo
Copy link
Owner

Nice, thank you @Torabek! 🤓

Good tip @Kludex! Thanks! I was precisely thinking about something like this. I'll probably have to do it in a custom script/action as the source is in YAML, but the markdown one looks interesting as well for other places. 🤔

@tiangolo tiangolo merged commit ea84587 into tiangolo:master Jan 12, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation about how to use FastAPI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants