New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃摑 Reword in docs, from "have in mind" to "keep in mind" #10376
Conversation
"Keep in mind" is how you would express this in an imperative form. First pass was done on macOS 10.15 with: LC_ALL=C find docs -type f -exec sed -i '' 's/Have in mind/Keep in mind/g' '{}' + LC_ALL=C find docs -type f -exec sed -i '' 's/have in mind/keep in mind/g' '{}' + git restore docs/en/docs/img
馃摑 Docs preview for commit 5805b10 at: https://75293bc4.fastapitiangolo.pages.dev |
As a non-native speaker I wondered if The definition of have in mind:
The definition of keep in mind:
So I think both versions are valid, but the later fits the situations it is used in the documentation better. Another random discussion in a language forum:
Based on that information, I support that change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All proposed changes make sense.
However there are places left in the code that the regex you used didn't catch. I found them by searching for in mind
:
- https://github.com/malicious/fastapi/blob/e09646441d67ea59e2daece896d027dc5a067815/docs/en/docs/benchmarks.md#L5
- https://github.com/malicious/fastapi/blob/5805b1051464b2b9a0824243535fe43b251141d8/docs/en/docs/deployment/manually.md#L17
- https://github.com/malicious/fastapi/blob/0976185af96ab2ee39c949c0456be616b01f8669/docs/en/docs/tutorial/sql-databases.md#L304
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @malicious! 馃
And thanks for the review @gregmuellegger 馃攳
@malicious, would you please implement the suggestions from @gregmuellegger?
docs/en
: Replace "have in mind" with "keep in mind"Found by searching docs for "in mind".
馃摑 Docs preview for commit d9f8b01 at: https://6975e493.fastapitiangolo.pages.dev |
Thank you! @malicious 馃 And thanks for the help too @gregmuellegger 馃樃 |
"Keep in mind" is how you would express this in an imperative form.
First pass was done on macOS 10.15 with: