Support automatic generation of values for[MatrixDataSource] when using bool? and TEnum?
#2088
+91
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
andrewimcclement
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
andrewimcclement
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
andrewimcclement
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
andrewimcclement
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
|
Thanks @andrewimcclement ! |
|
Hmm. Looks like I broke something :( |
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
|
Thanks for fixing it up - didn't have time to keep working on it. |
|
@thomhurst @andrewimcclement - This PR seems to break the creation of an After the update, instead of >2800 tests, I only get 50 tests that are created. |
|
@samtrion oh really? Can you give a repro and I'll take a look? |
I will try to provide you with one for reproduction in the course of the evening. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings TUnit inline with NUnit
[Values]/[Theory]value generation.