CompletesWithin(TimeSpan) and ThrowsWithin(TimeSpan) assertions

[thomhurst]

cc @AlexandreBossard

[AlexandreBossard]

Thank you !
Looking at your code, it's not clear to me that the Task will be aborted if it exceed the TimeSpan ?

[thomhurst]

Thank you ! Looking at your code, it's not clear to me that the Task will be aborted if it exceed the TimeSpan ?

You're right, it wouldn't. The assertions library isn't currently set up to abort tasks. I'd need to pass a cancellation token to the delegate used in the Assert.That and you'd need to use that in your task. Is that how FA did it?

[AlexandreBossard]

The assertions library isn't currently set up to abort tasks

Yeah that's what I figured when I tried it myself.

FA don't bother with cancellation token. It creates a new Task with a Timer and use Task.WhenAny(target, timeoutTask) for timeouts and manually cancel the operation. The code is here.

[thomhurst]

The assertions library isn't currently set up to abort tasks

Yeah that's what I figured when I tried it myself.

FA don't bother with cancellation token. It creates a new Task with a Timer and use Task.WhenAny(target, timeoutTask) for timeouts and manually cancel the operation. The code is here.

From what I can tell, that won't cancel that task, it'll just leave it in the background. But it does solve the problem of not waiting for it which TUnit currently would. I'll have to have a think. Might be a chunky refactor.