Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid type errors when public key is not retrieved #1446

Merged
merged 1 commit into from
Apr 14, 2022
Merged

Avoid type errors when public key is not retrieved #1446

merged 1 commit into from
Apr 14, 2022

Commits on Apr 14, 2022

  1. Avoid type errors when public key is not retrieved 

    When dealing with unstable connections, phpseclib may return `false`
when retrieving the public key.  That causes `null` to be passed down to
`base64_decode()` and triggers a TypeError due to strict types.

This exits early, preventing triggering the problem. However, testing is
a bit tricky since we need an unstable connection.
    @lcobucci
    lcobucci committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    ec4d8a8 View commit details
    Browse the repository at this point in the history