feat: allow bypass of duplicate errors #139
Merged
+61
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
golanglemonade
requested review from
matoszz,
LemonAid711 and
theopenlane-bender
Signed-off-by: Sarah Funkhouser <147884153+golanglemonade@users.noreply.github.com>
|
matoszz
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When someone is doing an update on an object, they can add the same edge that already exists; however, we then try to re-add the tuple which fails.
This change will ignore duplicate (or non-existent) keys and just log a warning.
This is configurable by a config var, but defaults to
true.The duplicate error string check is kind of annoying, and it's on the OpenFGA backlog of making it better, but for now its the best way. (They always return a 400/bad request on these and you have to string match the error)