Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): add With Icon storybook #1316

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

paghar
Copy link
Contributor

@paghar paghar commented Mar 26, 2024

Add "With Icon" storybook

There are no breaking API changes.

Summary by CodeRabbit

  • New Features
    • Added a new story WithIconList to the List component in UI documentation, demonstrating lists with icons using HiCheckCircle.

Copy link

stackblitz bot commented Mar 26, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

vercel bot commented Mar 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowbite-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 26, 2024 10:37am

Copy link
Contributor

coderabbitai bot commented Mar 26, 2024

Walkthrough

This update introduces a new visual story to the List component, showcasing a list with icons using HiCheckCircle from react-icons/hi. It enhances the component's visual presentation and demonstrates its flexibility in handling icon integration.

Changes

File Change Summary
.../src/components/List/... Added WithIconList story showcasing a list with icons

🐇✨
In the realm of code, where stories unfold,
A new tale of icons, so bold.
With checks of green, in lists they gleam,
A rabbit's work, a developer's dream.
🌟📚

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@paghar paghar force-pushed the feat/list-with-icon-stories branch from bf640db to 6a47ef3 Compare March 26, 2024 08:11
@paghar
Copy link
Contributor Author

paghar commented Mar 26, 2024

@SutuSebastian Hey dear Sebastian, pls take a look at this change...

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 8c1e992 and bf640db.
Files selected for processing (1)
  • packages/ui/src/components/List/List.stories.tsx (2 hunks)
Additional comments: 2
packages/ui/src/components/List/List.stories.tsx (2)
  • 4-4: The import of HiCheckCircle from react-icons/hi is correctly done and is essential for the new WithIconList story.
  • 101-111: The WithIconList story is correctly added and follows the established pattern for story definitions. It effectively demonstrates the integration of icons within the list component.

Please ensure that the List.Item component properly supports the icon prop as used here.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 8c1e992 and 6a47ef3.
Files selected for processing (1)
  • packages/ui/src/components/List/List.stories.tsx (2 hunks)
Files skipped from review as they are similar to previous changes (1)
  • packages/ui/src/components/List/List.stories.tsx

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between c4317a5 and daf7944.
Files selected for processing (1)
  • packages/ui/src/components/List/List.stories.tsx (2 hunks)
Files skipped from review as they are similar to previous changes (1)
  • packages/ui/src/components/List/List.stories.tsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants