Monorepo conversion (using bun)
#1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
January 16, 2024 13:37
- bun [runtime, package manager, task runner, test runner] - biome [format, lint] - removed `cypress` (to be replaced with `playwright`) - removed codecov - split into multiple packages and apps [web(docs), ui(library), storybook, cli] UNSTABLE
fix(ui): exports fix(root): sort `package.json`
- replace `@vitejs/plugin-react-sw` -> `@vitejs/plugin-react` - fix build - add `.gitignore` - update stories path
- remove more biome leftover - add package json sorter
…class sorting, linting and apply fixes
- add `eslint` to `web` - optimise onboarding flow - fix tailwind lint errors here and there
- refactor github actions - setup github actions using `bun` - remove storybook github action (redo later)
SutuSebastian
added
the
📚 documentation
…0.31` due to storybook failing; update some packages
|
@coderabbitai resume |
rluders
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
All right. This PR is waaaay too big to be reviewed properly. My browser is struggling to pass through all the changes. However, I've been following the changes for ~2 months, and today I tested it locally. I didn't notice any immediate problem. Nothing seems to be broken at first glance, and I think that the benefits of getting it merged are bigger than the risks related to it. So... I'm approving this PR.
Good job, @SutuSebastian! This is a great improve.
|
This is an amazing PR @SutuSebastian. Good job! |
This was referenced May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since there is a lot of confusion regarding which files belong to docs, and which belong to the UI library, as well as which files are simply for code quality and which not, we should have a split bringing separation of concerns that isolates each app/package into their own namespace, while still allowing the flexibility of re-usage of one another (eg: UI lib being used in docs namespace).
To achieve this, the answer is monorepo.
Structure
Stack
Task runner:
BunPackage manager:
BunLint:
ESLintFormat:
PrettierTest:
VitestRelease:
ChangesetsMonorepo:
BunMonorepo build system:
TurborepoChanges
General:
buncypress(to be replaced withplaywright)codecovDocs:
CLIpageEditor SetuppageQuickstartpagemodematches)UI library:
themeobjects, usingcreateTheme()proxy functionvitestto latestStorybook:
CLI:
create-flowbite-reactCLI package (https://www.npmjs.com/package/create-flowbite-react)Result
Docs - Quickstart
Screen.Recording.2024-03-20.at.10.49.40.mov
Docs - Integration Guides - CLI section
Docs - code preview
Screen.Recording.2024-03-20.at.10.53.50.mov
Screen.Recording.2024-03-20.at.10.54.21.mov
Storybook - light/dark mode toggle
Screen.Recording.2024-03-20.at.11.25.21.mov
CLI
Screen.Recording.2024-03-20.at.11.04.27.mov