fix(button): Button ring on focus #1238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes the button inconsistent focus ring compared to the core library. It also adds a transition of colors and ring
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1238 +/- ##
==========================================
- Coverage 99.54% 97.36% -2.18%
==========================================
Files 163 214 +51
Lines 6621 9077 +2456
Branches 401 530 +129
==========================================
+ Hits 6591 8838 +2247
- Misses 30 239 +209 ☔ View full report in Codecov by Sentry. |
abdulbasithqb
pushed a commit
to abdulbasithqb/flowbite-react
that referenced
this pull request
Jan 31, 2024
fix(button): fix button ring on focus fixes the button inconsistent focus ring compared to the core library. It also adds a transition of colors and ring
abdulbasithqb
pushed a commit
to abdulbasithqb/flowbite-react
that referenced
this pull request
Jan 31, 2024
fix(button): fix button ring on focus fixes the button inconsistent focus ring compared to the core library. It also adds a transition of colors and ring
Merged
This was referenced May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes the button inconsistent focus ring compared to the core library. It also adds a transition of colors and ring
Summarize the changes made and the motivation behind them.
This PR fixes the button focus ring, which is currently inconsistent with the core library. The Button Group ring was wrongly overriding the ring-4 classes defined in the button themes.
Also, I took the opportunity to add a slight transition on the button colors/shadows to have the hover and the ring styles animated
Reference related issues using
#followed by the issue number.If there are breaking API changes - like adding or removing props, or changing the structure of the theme - describe them, and provide steps to update existing code.