feat: Popover component #1237
Merged
feat: Popover component #1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR creates the Popover component based on the specs of the core library fix themesberg#916 fix themesberg#878
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1237 +/- ##
==========================================
- Coverage 99.54% 97.38% -2.16%
==========================================
Files 163 217 +54
Lines 6621 9225 +2604
Branches 401 538 +137
==========================================
+ Hits 6591 8984 +2393
- Misses 30 241 +211 ☔ View full report in Codecov by Sentry. |
SutuSebastian
approved these changes
Jan 23, 2024
SutuSebastian
added
📚 documentation
abdulbasithqb
pushed a commit
to abdulbasithqb/flowbite-react
that referenced
this pull request
Jan 31, 2024
* feat(popover): created Popover component This PR creates the Popover component based on the specs of the core library fix themesberg#916 fix themesberg#878 * docs(popover): created document page of Popover component with examples * refact(popover): removed unnecessary code * docs(popover): improved documentation * fix(popover): import correct theme props * refact(popover): use relative imports * docs(popover): reverted import paths
abdulbasithqb
pushed a commit
to abdulbasithqb/flowbite-react
that referenced
this pull request
Jan 31, 2024
* feat(popover): created Popover component This PR creates the Popover component based on the specs of the core library fix themesberg#916 fix themesberg#878 * docs(popover): created document page of Popover component with examples * refact(popover): removed unnecessary code * docs(popover): improved documentation * fix(popover): import correct theme props * refact(popover): use relative imports * docs(popover): reverted import paths
|
this component is documented as ready, but it's not present on last version (0.7.2). |
The next version of this repo (switching it to monorepo) will include a better way to have a 1-to-1 docs<->npm correlation. |
Merged
This was referenced May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize the changes made and the motivation behind them.
This PR creates the Popover component based on the specs of the core library. It also gets some examples from there
Reference related issues using
#followed by the issue number.fix #916 fix #878
This also impacts #1095. The user will be able to build their own form structures inside Popovers without facing the a11y issues with typehead in Dropdowns
If there are breaking API changes - like adding or removing props, or changing the structure of the theme - describe them, and provide steps to update existing code.