feat(component): default to type="text" on <TextInput>
#1206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All of the other form components provide an implicit `type=".."` field so this one should, too. It is implied by the name that this will be an `<input type="text">` by default, and you have the *option* to provide a specific other `type`.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
SutuSebastian
approved these changes
Jan 1, 2024
ddiasfront
pushed a commit
to ddiasfront/flowbite-react
that referenced
this pull request
Jan 1, 2024
…g#1206) All of the other form components provide an implicit `type=".."` field so this one should, too. It is implied by the name that this will be an `<input type="text">` by default, and you have the *option* to provide a specific other `type`.
Merged
This was referenced May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of the other form components provide an implicit
type=".."field so this one should, too. It is implied by the name that this will be an<input type="text">by default, and you have the option to provide a specific othertype.Make
<TextInput>s slightly more convenient when thetype="text", since "Text input" implies that.No breaking changes!
type="text"typed explicitly will still work, but won't be necessary anymore. Explicittype="search", etc. will work the same.