🎒backport advanced scope helpers from v4 -> v3 #980
Merged
+79
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In v4, the `Scope` interface got a little more powerful 💪💪 Specifically, it got an `expect()` helper to throw an error if a context is missing. It's the scope equivalent of `Context.expect()`. Also, there is a `hasOwn()` helper which is necessary for some cases where there needs to be a single context value per task. Finally, there is `delete()` which is very rarely used, but rounds out the API, and since it's present in v4, it's probably a good idea to add it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In v4, the
Scopeinterface got a little more powerful 💪💪Specifically, it got an
expect()helper to throw an error if a context is missing. It's the scope equivalent ofContext.expect(). Also, there is ahasOwn()helper which is necessary for some cases where there needs to be a single context value per task.Finally, there is
delete()which is very rarely used, but rounds out the API, and since it's present in v4, it's probably a good idea to add it.Approach
Bring the methods on over, along with some tests.