Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize the bidirectional link idea to all products #1734

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

hasparus
Copy link
Collaborator

@hasparus hasparus commented Oct 17, 2024

@saihaj (I think?) proposed linking from docs to landing and landing to docs from Hive tile in Products submenu.
I'm adding new UI to other websites, so I generalized this behavior. Linking to the page I'm already on isn't useful (can always refresh), so I think this matches expectations.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link

changeset-bot bot commented Oct 17, 2024

🦋 Changeset detected

Latest commit: 54e2501

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@theguild/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hasparus hasparus force-pushed the generalized-bidirectional-links branch from 66eef0e to 2e4ae5b Compare October 17, 2024 14:42
Copy link
Contributor

github-actions bot commented Oct 17, 2024

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@theguild/components 7.0.1-alpha-20241017144529-54e250136451f909f7d8d943756aa9ca255c7e2f npm ↗︎ unpkg ↗︎

@hasparus hasparus force-pushed the generalized-bidirectional-links branch from 2e4ae5b to 54e2501 Compare October 17, 2024 14:44
Copy link
Contributor

📚 Storybook Deployment

The latest changes are available as preview in: https://a098b0be.the-guild-docs-storybook.pages.dev

Base automatically changed from export-cn to main October 17, 2024 17:27
@saihaj saihaj merged commit 592b8d3 into main Oct 17, 2024
5 checks passed
@saihaj saihaj deleted the generalized-bidirectional-links branch October 17, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants