@theguild/components v7 #1587
Merged
@theguild/components v7 #1587
+3,929
−435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimaMachina
commented
Aug 2, 2024
🦋 Changeset detectedLatest commit: 489e458 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Merged
dimaMachina
commented
Aug 2, 2024
dimaMachina
commented
Aug 2, 2024
Co-authored-by: Dimitri POSTOLOV <dmytropostolov@gmail.com>
📚 Storybook DeploymentThe latest changes are available as preview in: https://8ffe282d.the-guild-docs-storybook.pages.dev |
dimaMachina
commented
Oct 8, 2024
Comment on lines
+327
to
+342
| [ | ||
| 'Documentation', | ||
| PaperIcon, | ||
| isHive ? '/docs' : 'https://the-guild.dev/graphql/hive/docs', | ||
| ], | ||
| ['Status', TargetIcon, 'https://status.graphql-hive.com/'], | ||
| [ | ||
| 'Product Updates', | ||
| RightCornerIcon, | ||
| isHive | ||
| ? '/product-updates' | ||
| : 'https://the-guild.dev/graphql/hive/product-updates', | ||
| ], | ||
| ['Blog', PencilIcon, 'https://the-guild.dev/blog'], | ||
| ['GitHub', GitHubIcon, 'https://github.com/kamilkisiela/graphql-hive'], | ||
| ] as const |
There was a problem hiding this comment.
use object, not tuple
There was a problem hiding this comment.
This is immediately mapped into JSX, so any property keys just bloat the bundle — this is why I just used tuples here.
Do you guys have a convention against tuples? Also cc @saihaj because I think he gave me the same comment elsewhere.
I don't mind changing it, I'm just curious.
There was a problem hiding this comment.
in future Nextra 4 _meta.js will be server components, so this will not increase bundle
dimaMachina
commented
Oct 8, 2024
Comment on lines
+355
to
+362
| [ | ||
| 'YouTube', | ||
| YouTubeIcon, | ||
| 'https://www.youtube.com/watch?v=d_GBgH-L5c4&list=PLhCf3AUOg4PgQoY_A6xWDQ70yaNtPYtZd', | ||
| ], | ||
| ['X', TwitterIcon, 'https://x.com/theguilddev'], | ||
| ['LinkedIn', LinkedInIcon, 'https://www.linkedin.com/company/the-guild-software/'], | ||
| ['Discord', DiscordIcon, 'https://discord.com/invite/xud7bH9'], |
There was a problem hiding this comment.
same, object, not tuple
dimaMachina
commented
Oct 8, 2024
| // These icons are _different_ than the ones used elsewhere. | ||
| // e.g. Discord is a "chat" bubble with the Discord logo in the center. | ||
|
|
||
| function YouTubeIcon(props: React.SVGProps<SVGSVGElement>) { |
dimaMachina
commented
Oct 8, 2024
| ); | ||
| } | ||
|
|
||
| function TwitterIcon(props: React.SVGProps<SVGSVGElement>) { |
dimaMachina
commented
Oct 8, 2024
| ); | ||
| } | ||
|
|
||
| function LinkedInIcon(props: React.SVGProps<SVGSVGElement>) { |
dimaMachina
commented
Oct 8, 2024
| ); | ||
| } | ||
|
|
||
| function DiscordIcon(props: React.SVGProps<SVGSVGElement>) { |
dimaMachina
commented
Oct 8, 2024
| const marker = markerRef.current; | ||
| const observer = new IntersectionObserver(entries => { | ||
| onChangeRef.current(entries[0].boundingClientRect.y < -1); | ||
| }, {}); |
There was a problem hiding this comment.
Suggested change
| }, {}); | |
| }); |
dimaMachina
commented
Oct 8, 2024
| onChangeRef.current = onChange; | ||
|
|
||
| useEffect(() => { | ||
| if (mounted && markerRef.current && 'IntersectionObserver' in window) { |
There was a problem hiding this comment.
Suggested change
| if (mounted && markerRef.current && 'IntersectionObserver' in window) { | |
| if (mounted && markerRef.current) { |
it's available in all modern browsers
dimaMachina
commented
Oct 8, 2024
| > | ||
| <NavigationMenuPrimitive.Viewport | ||
| className={cn( | ||
| 'relative mt-1.5 h-[var(--radix-navigation-menu-viewport-height)] w-[var(--radix-navigation-menu-viewport-width)] origin-[top_center] overflow-hidden rounded-xl border border-beige-200 bg-white shadow-[0px_16px_32px_-12px_rgba(14,18,27,0.10)] ease-in-out data-[state=open]:animate-in data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=open]:fade-in-90 data-[state=closed]:zoom-out-95 data-[state=open]:zoom-in-90 dark:border-neutral-800 dark:bg-neutral-900', |
There was a problem hiding this comment.
Suggested change
| 'relative mt-1.5 h-[var(--radix-navigation-menu-viewport-height)] w-[var(--radix-navigation-menu-viewport-width)] origin-[top_center] overflow-hidden rounded-xl border border-beige-200 bg-white shadow-[0px_16px_32px_-12px_rgba(14,18,27,0.10)] ease-in-out data-[state=open]:animate-in data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=open]:fade-in-90 data-[state=closed]:zoom-out-95 data-[state=open]:zoom-in-90 dark:border-neutral-800 dark:bg-neutral-900', | |
| 'relative mt-1.5 h-[--radix-navigation-menu-viewport-height] w-[--radix-navigation-menu-viewport-width] origin-[top_center] overflow-hidden rounded-xl border border-beige-200 bg-white shadow-[0px_16px_32px_-12px_rgba(14,18,27,0.10)] ease-in-out data-[state=open]:animate-in data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=open]:fade-in-90 data-[state=closed]:zoom-out-95 data-[state=open]:zoom-in-90 dark:border-neutral-800 dark:bg-neutral-900', |
use shorthand
dimaMachina
commented
Oct 8, 2024
Comment on lines
16
to
18
| render() { | ||
| return <ToolsAndLibrariesCards />; | ||
| }, |
There was a problem hiding this comment.
Suggested change
| render() { | |
| return <ToolsAndLibrariesCards />; | |
| }, | |
| render: ToolsAndLibrariesCards, |
dimaMachina
commented
Oct 8, 2024
| const cardDecorations = { | ||
| [PRODUCTS.HIVE.name](props: React.SVGAttributes<SVGSVGElement>) { | ||
| return ( | ||
| <svg |
dimaMachina
commented
Oct 8, 2024
dimaMachina
commented
Oct 8, 2024
dimaMachina
commented
Oct 8, 2024
Co-authored-by: Dimitri POSTOLOV <dmytropostolov@gmail.com>
Co-authored-by: Dimitri POSTOLOV <dmytropostolov@gmail.com>
Co-authored-by: Dimitri POSTOLOV <dmytropostolov@gmail.com>
Co-authored-by: Dimitri POSTOLOV <dmytropostolov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.