Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade Prometheus version to latest main #435

Merged
merged 4 commits into from Mar 27, 2024

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Mar 27, 2024

Upgrade Prometheus version to latest main to unblock upgrading prometheus version in Thanos main repo.

Signed-off-by: Ben Ye <benye@amazon.com>
@fpetkovski
Copy link
Collaborator

Looks like we might need to bump the go version.

Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: Ben Ye <benye@amazon.com>
@yeya24
Copy link
Contributor Author

yeya24 commented Mar 27, 2024

Something seems wrong for this version upgrade. I don't think it is an issue on us. Maybe upstream changed something?

--- FAIL: FuzzEnginePromQLSmithInstantQuery (0.88s)
    --- FAIL: FuzzEnginePromQLSmithInstantQuery (0.23s)
        enginefuzz_test.go:449: load 30s
            			http_requests_total{pod="nginx-1", route="/"} 600.00+10.00x40
            			http_requests_total{pod="nginx-2", route="/"}  8+28.00x40
        enginefuzz_test.go:451: increase({__name__="http_requests_total",route="/"} offset 1m7s[1h:1m] offset -3m33s)
        enginefuzz_test.go:453: case 71 error mismatch.
            new result: {pod="nginx-1", route="/"} => 55.666666666666664 @[44000]
            {pod="nginx-2", route="/"} => 163.86666666666667 @[44000]
            old result: {pod="nginx-1", route="/"} => 55.666666666666664 @[44000]
            {pod="nginx-2", route="/"} => 155.86666666666667 @[44000]
        enginefuzz_test.go:458: failed 1 test cases

@MichaHoffmann
Copy link
Contributor

Probably something around rate and increase changed in upstream?

@GiedriusS
Copy link
Member

prometheus/prometheus#13725 maybe this one?

Signed-off-by: Ben Ye <benye@amazon.com>
Copy link
Contributor

@MichaHoffmann MichaHoffmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MichaHoffmann MichaHoffmann merged commit 35ca65e into thanos-io:main Mar 27, 2024
7 checks passed
@yeya24 yeya24 deleted the upgrade-prometheus-version branch March 27, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants