Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streamline Data Provider execution #3092

Merged
merged 1 commit into from Mar 16, 2024
Merged

Streamline Data Provider execution #3092

merged 1 commit into from Mar 16, 2024

Conversation

krmahadevan
Copy link
Member

@krmahadevan krmahadevan commented Mar 16, 2024 •
edited by coderabbitai bot

Closes #3081

Fixes #3081 .

Did you remember to?

  • Add test case(s)
  • Update CHANGES.txt
  • Auto applied styling via ./gradlew autostyleApply

We encourage pull requests that:

  • Add new features to TestNG (or)
  • Fix bugs in TestNG

If your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the
TestNG-dev before you spend time working on it.

Note: For more information on contribution guidelines please make sure you refer our Contributing section for detailed set of steps.

Summary by CodeRabbit

  • New Features

    • Introduced an Async class for executing tasks asynchronously, enhancing test execution efficiency.
    • Implemented a comparable interface in TestMethodWithDataProviderMethodWorker for prioritizing test methods.

  • Bug Fixes

    • Fixed discrepancies related to listener inclusion at runtime and correct instance return during certain method invocations.

  • Tests

    • Added new test methods to ensure no exceptions when running in shared thread pools with method interceptors.
    • Introduced test classes demonstrating parallel data providers and concurrent test execution.

  • Documentation

    • Documented the project's PGP artifact signing keys.

  • Refactor

    • Replaced static import with a method call to improve code maintainability.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Mar 16, 2024 •
edited

Warning

Rate Limit Exceeded

@krmahadevan has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 14 minutes and 34 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between 93ec005 and c2ee729.

Walkthrough

These changes focus on enhancing parallel test execution and data provider usage with method interceptors in the TestNG framework. They address issues related to shared thread pool discrepancies, method interception, and prioritization of test methods. Additionally, a new class Async is introduced for asynchronous task execution, contributing to more efficient testing processes.

Changes

File Path Change Summary
CHANGES.txt Fixed discrepancies related to shared thread pool, method interceptor, listener inclusion, instance return, and PGP keys documentation.
.../internal/invokers/MethodRunner.java
.../internal/invokers/TestMethodWithDataProviderMethodWorker.java
.../thread/Async.java		 Adjusted for asynchronous task execution and comparison of test method priorities.
.../test/java/test/dataprovider/DataProviderTest.java
.../test/java/test/dataprovider/issue3081/NoOpMethodInterceptor.java
.../test/java/test/dataprovider/issue3081/TestClassSample.java
.../test/java/test/dataprovider/issue3081/TestClassWithPrioritiesSample.java		 Enhanced tests for shared thread pools with method interceptors and priorities handling.

Assessment against linked issues

Objective Addressed Explanation
Set up a proof of concept project to explore new features related to parallelization. (#3081) ❌ The changes do not explicitly mention setting up a new proof of concept project.
Encounter and address a ClassCastException error related to CompletableFuture$AsyncSupply and Comparable classes. (#3081) ✅
Utilize TestNG for testing with a shared thread pool for data providers and parallel test execution. (#3081) ✅
Verify the Maven command for running tests with a specified thread count (-DthreadCount=10). (#3081) ❌ There is no direct mention of validating or updating Maven commands in the provided changes.

Poem

In the realm of code, where changes unfold,
Bugs are fixed, and tests are bold.
🐇 With each tweak, TestNG shines bright,
Parallel paths, leading to the light.
A rabbit's touch, a magical sign,
Guiding the code to a future divine.
🌟 Onward we go, with tests aligned!

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

coderabbitai[bot]
coderabbitai bot reviewed Mar 16, 2024
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 93ec005 and 39909c1.
Files selected for processing (8)
  • CHANGES.txt (1 hunks)
  • testng-core/src/main/java/org/testng/internal/invokers/MethodRunner.java (3 hunks)
  • testng-core/src/main/java/org/testng/internal/invokers/TestMethodWithDataProviderMethodWorker.java (2 hunks)
  • testng-core/src/main/java/org/testng/thread/Async.java (1 hunks)
  • testng-core/src/test/java/test/dataprovider/DataProviderTest.java (2 hunks)
  • testng-core/src/test/java/test/dataprovider/issue3081/NoOpMethodInterceptor.java (1 hunks)
  • testng-core/src/test/java/test/dataprovider/issue3081/TestClassSample.java (1 hunks)
  • testng-core/src/test/java/test/dataprovider/issue3081/TestClassWithPrioritiesSample.java (1 hunks)
Files skipped from review as they are similar to previous changes (8)
  • CHANGES.txt
  • testng-core/src/main/java/org/testng/internal/invokers/MethodRunner.java
  • testng-core/src/main/java/org/testng/internal/invokers/TestMethodWithDataProviderMethodWorker.java
  • testng-core/src/main/java/org/testng/thread/Async.java
  • testng-core/src/test/java/test/dataprovider/DataProviderTest.java
  • testng-core/src/test/java/test/dataprovider/issue3081/NoOpMethodInterceptor.java
  • testng-core/src/test/java/test/dataprovider/issue3081/TestClassSample.java
  • testng-core/src/test/java/test/dataprovider/issue3081/TestClassWithPrioritiesSample.java

@krmahadevan krmahadevan requested a review from juherr March 16, 2024 07:58
@krmahadevan krmahadevan merged commit 15874ea into testng-team:master Mar 16, 2024
7 of 9 checks passed
@krmahadevan krmahadevan deleted the fix_3081 branch March 16, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai left review comments

@juherr juherr juherr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Discrepancy with combination of (Shared Thread pool and Method Interceptor)
2 participants
@krmahadevan @juherr