Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ParallelSuiteTest #2687

Merged
merged 5 commits into from
Dec 12, 2021

Commits on Dec 8, 2021

  1. Enable ParallelSuiteTest

    Presumably, test was disabled to get rid of distraction during development
    and was forgotten.
    
    Test was broken and commented out temporary back in 2011 in
    cc950e9 commit, named `Temp commit`.
    Commit was introduced in `AllDynamic` branch
    
    Test is green both on the base commit of AllDynamic branch (10a202a) as well as on branch merge point (b251fce)
    
    Done:
    - Add test: child suite should obey threadCount parameter
    - Move private stuff to bottom, add more details in error message
    sankouski-dzmitry committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    a231ff9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f43fc9a View commit details
    Browse the repository at this point in the history
  3. Fix populateSuiteGraph method: add parent nodes, too

    Before this, populateSuiteGraph method was ignoring any suite runner with child suites.
    This leads to parallel suites not being executed with `randomize suite` option enabled
    
    The method now add all nodes, including parents into the graph.
    sankouski-dzmitry committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    af8c3b6 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2021

  1. Adjust expected results for suitesShouldRunInParallel4

    This test implied a requirement to exclude duplicating suite files from run.
    For example, for suite graph like:
    
    suite-parallel-1.xml suite-parallel-2.xml suite-parallel-2-1.xml suite-parallel-2-2.xml
                                    |                                            |
                                    |                                            |
                          ---------- ---------|                                  v
                          v                   v                         suite-parallel-2-2-1.xml
                suite-parallel-2-1.xml suite-parallel-2-2.xml
                                                         |
                                                         |
                                                         v
                                                suite-parallel-2-2-1.xml
    
    a test expected 5 suites and 5 threads.
    
    However, this test was excluded from TestNG unit tests since 2011, and broken somewhere later
    on the timeline. Dropping mentioned requirement (i.e. leaving things as it is now),
    since there's no complains on current behaviour by adjusting test expected results, to
    8 expected suites and 8 threads.
    Dzmitry Sankouski authored and sankouski-dzmitry committed Dec 10, 2021
    Configuration menu
    Copy the full SHA
    51b3219 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2021

  1. review fixes:

    - revert  suite order
    - gradle autostyle apply
    - set parallel mode recursively
    Dzmitry Sankouski committed Dec 11, 2021
    Configuration menu
    Copy the full SHA
    b60739a View commit details
    Browse the repository at this point in the history