Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(await-async-events): setup() incorrectly reported from a wrapper #840

Closed
wants to merge 1 commit into from
Closed

fix(await-async-events): setup() incorrectly reported from a wrapper #840

wants to merge 1 commit into from

Conversation

trungutt
Copy link

@trungutt trungutt commented Nov 3, 2023 •
edited

Checks

Changes

  • userEvent.setup() is sync. So we shouldn't report any async linting error on it

Context

@trungutt
fix(await-async-events): non-async userEvent.setup() should not be in…
9eb12e9 
…valid

Signed-off-by: Trung Nguyen <trung.nguyen@docker.com>
@trungutt
Copy link
Author

trungutt commented Nov 8, 2023

@Belco90 it sounds like you would be the right reviewer. Could you PTAL?

@Belco90 Belco90 assigned Belco90 and trungutt and unassigned Belco90 Nov 9, 2023
@Belco90 Belco90 self-requested a review November 9, 2023 08:26
@Belco90 Belco90 changed the title fix(await-async-events): userEvent.setup() should be sync fix(await-async-events): setup() incorrectly reported from a wrapper Nov 9, 2023
@Belco90
Copy link
Member

Belco90 commented Nov 9, 2023

Hi @trungutt. Thanks for your contribution! Can you check if this is still relevant after merging #834? If so, please update your branch accordingly.

@trungutt
Copy link
Author

trungutt commented Nov 9, 2023 •
edited

it should be good now, that PR #834 fixes the same issue

@trungutt trungutt closed this Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Belco90 Belco90 Awaiting requested review from Belco90

Assignees

@trungutt trungutt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

await-async-events reports a problem when userEvent.setup is called from another function
2 participants
@trungutt @Belco90