fix(await-async-events): sync userEvent.setup() should not be reported #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justintoman
changed the title
justintoman
changed the title
Belco90
approved these changes
Sep 23, 2023
Belco90
changed the title
|
🎉 This PR is included in version 6.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@all-contributors please add @justintoman for code and test |
|
I've put up a pull request to add @justintoman! 🎉 |
|
@Belco90 Isn't it okay to not have a such test? |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks
Changes
Context
Fixes #800
This is my first open source PR. I'd rather base the logic on the type of the call expression (is it a
Promise?), but I don't believe that information is available in the AST so I just went off of the identifier name.