Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't panic when logs waits for more than 5 seconds #947

Merged
merged 1 commit into from
Apr 24, 2023
Merged

fix: don't panic when logs waits for more than 5 seconds #947

merged 1 commit into from
Apr 24, 2023

Commits on Apr 24, 2023

  1. fix: don't panic when logs waits for more than 5 seconds 

    This removes panic when logs endpoint takes more than 5 seconds to respond.
The panic happened at least with podman when no new logs appear when using follow and since parameters.

We keep retrying until the context is canceled
(the retry request would fail anyway with canceled context)
or the producer is stopped,
whichever comes first.
This makes the retry behavior consistent with closed connections
handling.

This should fix testcontainers#946
    @martin-sucha
    martin-sucha committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    97ebbaa View commit details
    Browse the repository at this point in the history