Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reaper): fix race condition when reusing reapers #1904

Merged
merged 4 commits into from
Nov 8, 2023

Commits on Nov 5, 2023

  1. fix(reaper): fix race condition when reusing reapers

    Reaper reuse/creation logic has been adjusted to facilitate the reuse of already running reapers. This includes using a specific naming convention based on the session id, and handling failed container creation attempts due to name conflicts by retrieving the already running reaper container. This fixes a race condition when tests are run in parallel in multiple packages which renders global locks ineffective.
    lefinal committed Nov 5, 2023
    Configuration menu
    Copy the full SHA
    37d3093 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2023

  1. docs(reaper): make reaper recovery log entries the same

    The log message related to the reaper container in the reaper.go file has been updated for better clarity. The redundant phrase "Canceling creation -" has been removed as it does not provide additional relevant information, aiming to improve log readability.
    lefinal committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    109c3ac View commit details
    Browse the repository at this point in the history
  2. docs(reaper): improve documentation for issues during reaper recovery

    Further comments where added to error handling in the reaper.go file, to better account for possible race conditions. This includes conditions where a container creation fails due to name conflict but no containers are visible in list-requests. Additionally, a possible scenario where the container may have died between requests has been covered.
    lefinal committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    9004677 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2023

  1. Configuration menu
    Copy the full SHA
    181e7bc View commit details
    Browse the repository at this point in the history