Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: fix goroutine leaks #1358

Merged
merged 1 commit into from
Aug 9, 2023

Commits on Aug 6, 2023

  1. all: fix goroutine leaks

    Fixes various goroutine leaks by moving around and adding missing Close calls.
    
    Leaks were detected by github.com/AlexanderYastrebov/noleak by adding
    
    ```go
    // go get github.com/AlexanderYastrebov/noleak@latest
    // cat main_test.go
    package testcontainers
    
    import (
            "os"
            "testing"
    
            "github.com/AlexanderYastrebov/noleak"
    )
    
    func TestMain(m *testing.M) {
            os.Exit(noleak.CheckMain(m))
    }
    ```
    
    Not all leaks could be fixed e.g. due to testcontainers#1357 therefore this change
    does not add leak detector, only fixes.
    
    Updates testcontainers#321
    AlexanderYastrebov committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    2b055df View commit details
    Browse the repository at this point in the history