Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly set the Docker socket on Windows #1458

Merged
merged 65 commits into from Aug 11, 2023

Conversation

mdelapenya
Copy link
Collaborator

@mdelapenya mdelapenya commented Aug 8, 2023

What does this PR do?

In this PR, we are updating the following things:

Why is it important?

The Docker socket that was mounted in the Ryuk container was incorrect for Windows users, making the library useless. With this change we fix that for them.

At the same time, we want to create deterministic tests that are not affected by the local filesystem while running them, skipping those that are impossible to run at the moment because of the possible limitations of Docker for Windows.

Related issues

@mdelapenya mdelapenya requested a review from a team as a code owner August 8, 2023 11:06
@mdelapenya mdelapenya added the bug An issue with the library label Aug 8, 2023
@mdelapenya mdelapenya self-assigned this Aug 8, 2023
@netlify
Copy link

netlify bot commented Aug 8, 2023

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 22deaad
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/64d5d17e3e17390008d2568d
😎 Deploy Preview https://deploy-preview-1458--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdelapenya
Copy link
Collaborator Author

/windows-test

@mdelapenya
Copy link
Collaborator Author

/windows-test

@mdelapenya
Copy link
Collaborator Author

/windows-test

@mdelapenya
Copy link
Collaborator Author

/windows-test

@mdelapenya
Copy link
Collaborator Author

/windows-test

@mdelapenya
Copy link
Collaborator Author

/windows-test

@mdelapenya
Copy link
Collaborator Author

/windows-test

@mdelapenya
Copy link
Collaborator Author

/windows-test

@mdelapenya
Copy link
Collaborator Author

/windows-test

@mdelapenya
Copy link
Collaborator Author

/windows-test

@mdelapenya
Copy link
Collaborator Author

/windows-test

* main:
  chore: triple max timeout for the workflow run, which takes +10m (testcontainers#1474)
@mdelapenya
Copy link
Collaborator Author

/windows-test

@mdelapenya mdelapenya marked this pull request as draft August 9, 2023 15:57
* main:
  chore: increase timeout for go test and GH action steps (testcontainers#1475)
@mdelapenya
Copy link
Collaborator Author

/windows-test

@mdelapenya
Copy link
Collaborator Author

/windows-test

@mdelapenya
Copy link
Collaborator Author

/windows-test

* main:
  Add support for MongoDB testing module (testcontainers#1447)
  Support groups in dependabot updates (testcontainers#1459)
  chore: run modulegen tests on Windows (testcontainers#1478)
  Add default labels when Ryuk is disabled (testcontainers#1339)
  feat: add clickhouse module (testcontainers#1372)
@mdelapenya
Copy link
Collaborator Author

/windows-test

@mdelapenya
Copy link
Collaborator Author

/windows-test

@mdelapenya mdelapenya marked this pull request as ready for review August 10, 2023 14:49
@mdelapenya
Copy link
Collaborator Author

mdelapenya commented Aug 10, 2023

I think this is ready for a review. Once the Windows build finishes, I'm merging this PR as we could say that the containers can be created in both systems: Linux & Windows

@mdelapenya mdelapenya changed the title fix: set Windows' USERPROFILE env var alongside Unix's HOME fix: properly set the Docker socket on Windows Aug 10, 2023
@mdelapenya
Copy link
Collaborator Author

/windows-test

docker_test.go Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Aug 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
6.1% 6.1% Duplication

@mdelapenya
Copy link
Collaborator Author

I think this is good to be merged, as the build for the previous commit was green, and the last commit just removes a log entry. I'm merging the PR know.

@mdelapenya mdelapenya merged commit 9013d9a into testcontainers:main Aug 11, 2023
17 of 18 checks passed
@mdelapenya mdelapenya deleted the windows-tests branch August 11, 2023 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue with the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: invalid mount config for type "bind"
1 participant