New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: properly set the Docker socket on Windows #1458
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/windows-test |
/windows-test |
/windows-test |
/windows-test |
/windows-test |
/windows-test |
/windows-test |
/windows-test |
/windows-test |
/windows-test |
/windows-test |
…10m" This reverts commit 07811cb.
* main: chore: triple max timeout for the workflow run, which takes +10m (testcontainers#1474)
/windows-test |
* main: chore: increase timeout for go test and GH action steps (testcontainers#1475)
/windows-test |
/windows-test |
/windows-test |
* main: Add support for MongoDB testing module (testcontainers#1447) Support groups in dependabot updates (testcontainers#1459) chore: run modulegen tests on Windows (testcontainers#1478) Add default labels when Ryuk is disabled (testcontainers#1339) feat: add clickhouse module (testcontainers#1372)
/windows-test |
/windows-test |
I think this is ready for a review. Once the Windows build finishes, I'm merging this PR as we could say that the containers can be created in both systems: Linux & Windows |
/windows-test |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
I think this is good to be merged, as the build for the previous commit was green, and the last commit just removes a log entry. I'm merging the PR know. |
What does this PR do?
In this PR, we are updating the following things:
//var/run/docker.sock
%USERPROFILE%
env var too.filepath
to build an OS-agnostic file path.Why is it important?
The Docker socket that was mounted in the Ryuk container was incorrect for Windows users, making the library useless. With this change we fix that for them.
At the same time, we want to create deterministic tests that are not affected by the local filesystem while running them, skipping those that are impossible to run at the moment because of the possible limitations of Docker for Windows.
Related issues