-
-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: invalid mount config for type "bind" #1367
Comments
Interesting... we added explicit code to detect the DockerSocketPath directly from the Docker client in #1294 I wonder if you could debug your tests and put a break point in the |
As an update, I forcefully overrode the I haven't tested, but I assume this is a conflict in the |
We have setup a windows pipeline that runs the core library tests on a self-hosted windows host. Now I have a way to consistently reproduce the errors (I'm on a Mac M1 and VirtualBox/vagrant does not work well with virtualisation 😢) A recent CI execution on Windows: https://github.com/testcontainers/testcontainers-go/actions/runs/5784246467/job/15674572952, where I can see and reproduce many of the errors described here: Socket path calculation
invalid mount config for type "bind"
I'll prioritise this bug over anything else. |
@turt2live could you put a break point in docker_host.go L:169, and check the state of the testcontainers-go/internal/testcontainersdocker/docker_host.go Lines 168 to 171 in 2a844ea
I wonder if, for Windows, we would need to enrich that evaluation 🤔 also verifying that in
/ is prepended for Windows
|
Hey folks! I merged #1458 because I'm confident it fixes the library for Windows users. The key is https://github.com/testcontainers/testcontainers-go/pull/1458/files#diff-6063b4272c0c8023987dd0a86e67194c26ff5d12a21e45ef0c90685e0b35eff0R170-R173, where we want to force the Docker socket for Ryuk to be mounted on For awareness, we added a Windows workflow on GH, using a self-hosted Windows instance running on Azure, and I have run the tests for that PR in there many many times, fixing multiple tests that were not using OS-agnostic patterns (please see PR description). Because we are very careful with our cloud costs, we are not going to put this Windows workflow in front of the PRs we receive, but instead delegate to admins of the repo to manually post the We acknowledge that ideally any PR should be tested on Windows, but there are certain things that are more complex on Docker for Windows (please see the diff of that PR to see which tests we skipped for Windows and why (e.g. containers on multiple networks). We sincerely hope you can use the library again. Cheers! 👋 |
Can confirm the fix is working on Windows, and I'm seeing the new log lines at startup:
Thanks for taking a look at this so quickly! |
Testcontainers version
0.21.0
Using the latest Testcontainers version?
Yes
Host OS
Windows
Host arch
amd64
Go version
1.20.5
Docker version
Client: Cloud integration: v1.0.35 Version: 24.0.2 API version: 1.43 Go version: go1.20.4 Git commit: cb74dfc Built: Thu May 25 21:53:15 2023 OS/Arch: windows/amd64 Context: default Server: Docker Desktop 4.21.1 (114176) Engine: Version: 24.0.2 API version: 1.43 (minimum version 1.12) Go version: go1.20.4 Git commit: 659604f Built: Thu May 25 21:52:17 2023 OS/Arch: linux/amd64 Experimental: false containerd: Version: 1.6.21 GitCommit: 3dce8eb055cbb6872793272b4f20ed16117344f8 runc: Version: 1.1.7 GitCommit: v1.1.7-0-g860f061 docker-init: Version: 0.19.0 GitCommit: de40ad0
Docker info
What happened?
When running test-containers I get the following error:
It used to run without issues and it still does on Github Actions with a Linux host.
Relevant log output
No response
Additional information
No response
The text was updated successfully, but these errors were encountered: