Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glue: disable connection type and properties checks #759

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

bendrucker
Copy link
Member

@bendrucker bendrucker commented Nov 22, 2024

Relaxes type requirements where the provider resource has diverged from the API models:

hashicorp/terraform-provider-aws#37731

These types were confirmed by AWS support to be supported but not fully documented. They are also not available in types and enums in various SDKs, including the AWS Go SDK v2 which the Terraform AWS Provider uses.

So in effect, we can't validate these without maintaining a matching list of connection types.

Closes #757

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@bendrucker
Copy link
Member Author

I'm inclined to just remove the rule, but could also replace the implementation with a noop now that it's not actually generated.

@bendrucker bendrucker requested a review from wata727 December 2, 2024 22:42
Copy link
Member

@wata727 wata727 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

These types were confirmed by AWS support to be supported but not fully documented

😞

@wata727
Copy link
Member

wata727 commented Dec 3, 2024

could also replace the implementation with a noop

Yeah, this is a good approach since it avoids the "rule does not exist" error if compatibility is important. However, for now I agree to simply remove the rule.
In the future, we will need to decide how often we will introduce incompatibilities after the v1 release, and consider a procedure to replace them with noop in the meantime.

@bendrucker bendrucker merged commit 738cbca into master Dec 3, 2024
8 checks passed
@bendrucker bendrucker deleted the glue-relax-connection-types branch December 3, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

aws_glue_connection_invalid_connection_type missing support BIGQUERY and other values.
2 participants