Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin isbinaryfile to version 5.0.0 #3539

Merged
merged 4 commits into from
Feb 15, 2024
Merged

pin isbinaryfile to version 5.0.0 #3539

merged 4 commits into from
Feb 15, 2024

Conversation

busma13
Copy link
Contributor

@busma13 busma13 commented Feb 15, 2024

isbinaryfile updated the node engine to >=20.0.0 in version 5.0.1. Node engine was then changed to >=18.0.0 in version 5.0.2.

  • Add resolution in root package.json to pin the version to 5.0.0 until we drop node 16 support.
  • Add the same resolution in teraslice-cli package.json. This is needed because the npm teraslice-cli package has no yarn.lock and doesn't reference the root package.json of the monorepo in that environment.

ref: #3544

@busma13 busma13 requested review from jsnoble and godber February 15, 2024 16:12
@busma13 busma13 marked this pull request as ready for review February 15, 2024 16:17
Copy link
Member

@jsnoble jsnoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsnoble jsnoble merged commit c0fb331 into master Feb 15, 2024
39 checks passed
@jsnoble jsnoble deleted the pin-isbinaryfile-version branch February 15, 2024 16:56
godber pushed a commit that referenced this pull request Feb 20, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Revert any changes that were made in #3539, #3541, #3542, #3543, or
#3548.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants