Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TypeScript to 5.0.4 #7681

Merged
merged 14 commits into from
Jul 21, 2023
Merged

Conversation

mattsoulanille
Copy link
Member

To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.

@mattsoulanille
Copy link
Member Author

I removed @types/webgl-ext since it doesn't appear that we actually need it. It was causing type errors in ts5.

I had to add skipLibCheck to tfjs-inference since it depends on already-published versions of TFJS which still include @types/webgl-ext. skipLibCheck prevents typescript from type-checking the packages in node_modules.

@mattsoulanille mattsoulanille marked this pull request as ready for review July 20, 2023 00:49
Copy link
Collaborator

@chunnienc chunnienc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry for the late review and thanks!

@mattsoulanille mattsoulanille merged commit 983dc16 into tensorflow:master Jul 21, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants