-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webgpu: Remove bufSize from GPUData #7637
Conversation
The buffer size and usage are the attributes of GPUBuffer. So bufSize doesn't need to be provided extra in GPUData.
data.bufSize will be removed in tensorflow/tfjs#7637.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Is
|
Could you help update this doc, https://github.com/tensorflow/tfjs/blob/master/docs/OPTIMIZATION_PURE_GPU_PIPELINE.md? Or, it could be in a separate pr. |
Jiajia's PR only changes the API, which may impact the upcoming release. We will do the related refactoring after holidays. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM
PR #7651 fixes it. Thanks. |
|
|
Thanks! |
* Use data.buffer.size instead of data.bufSize data.bufSize will be removed in tensorflow/tfjs#7637. * remove buffer.size
The buffer size and usage are the attributes of GPUBuffer. So bufSize doesn't need to be provided extra in GPUData.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.