feat(lang): support include other git repo for envd functions/variables #808
Conversation
Signed-off-by: Keming <kemingyang@tensorchord.ai>
Signed-off-by: Keming <kemingyang@tensorchord.ai>
Signed-off-by: Keming <kemingyang@tensorchord.ai>
| @@ -0,0 +1,6 @@ | |||
| envdlib = include("https://github.com/kemingy/envdlib") | |||
There was a problem hiding this comment.
Should we embed the envdlib into the envd binary? git clone may take a long time, especially in China.
There was a problem hiding this comment.
It will be cached in ~/.cache/envd/envdlib/<repo>.
I tried to reduce the repo size with depth=1 but it failed to git pull, see go-git/go-git#305.
BTW, envdlib should be very small since it only contains README and envd files.
There was a problem hiding this comment.
If users want to use tensorboard, do they need to add envdlib = include("https://github.com/kemingy/envdlib") into the build.envd?
There was a problem hiding this comment.
I think it is not necessary if the envdlib is maintained by us. The feature can be used for third-party libs.
There was a problem hiding this comment.
Make sense. So shall we maintain the envdlib in envd or use git submodule?
I can create another PR to evaluate the envdlib and insert into envd.
There was a problem hiding this comment.
git submodule LGTM.
/cc @VoVAllen
And maybe we can maintain an example about using third-party plugins.
Should we merge the PR first?
There was a problem hiding this comment.
Can merge this one if it LGTY
| @@ -19,4 +19,7 @@ const ( | |||
| ruleShell = "shell" | |||
| ruleRun = "run" | |||
| ruleGitConfig = "git_config" | |||
| ruleInclude = "include" | |||
|
|
|||
| GitPrefix = "git@" | |||
There was a problem hiding this comment.
Maybe we should define the public const in a separate package, but LGTM now.
|
/lgtm testing muniu-bot |
|
/retest |
1 similar comment
|
/retest |
|
/test all |
|
/lgtm |
|
@zwpaper: No presubmit jobs available for tensorchord/envd@main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aseaday, gaocegege, kemingy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Please test the bot in #812 |
Signed-off-by: Keming kemingyang@tensorchord.ai
FAQ
loadis starlark keyword,importhas been reserved by starlark.