Support user metadata on activities and child/scheduled workflows #1719
+111
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
LGTM, but may have to wait for a 1.26 server release for temporalio/temporal#6412. Not sure why activity metadata test is failing though.
|
@cretz temporalio/temporal#6412 is already in |
Quinn-With-Two-Ns
force-pushed
the
issue-1673
branch
from
17e5bc3 to
bd154a4
Compare
yuandrew
approved these changes
Nov 21, 2024
| @@ -727,6 +731,7 @@ func (d *childWorkflowCommandStateMachine) getCommand() *commandpb.Command { | |||
| command := createNewCommand(enumspb.COMMAND_TYPE_START_CHILD_WORKFLOW_EXECUTION) | |||
| command.Attributes = &commandpb.Command_StartChildWorkflowExecutionCommandAttributes{StartChildWorkflowExecutionCommandAttributes: d.attributes} | |||
| command.UserMetadata = d.startMetadata | |||
| fmt.Println("command.UserMetadata", command.UserMetadata) | |||
There was a problem hiding this comment.
want to remove before merging?
internal/workflow.go
Outdated
|
|
||
| options.StaticDetails = workflowOptionsFromCtx.StaticDetails | ||
| options.StaticSummary = workflowOptionsFromCtx.StaticSummary | ||
| fmt.Println("$$$$$ options", options) |
Quinn-With-Two-Ns
force-pushed
the
issue-1673
branch
from
bd154a4 to
71c3f7a
Compare
ReyOrtiz
pushed a commit
to ReyOrtiz/temporal-sdk-go
that referenced
this pull request
Dec 5, 2024
…mporalio#1719) Support user metadata on activities and child/scheduled workflows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support user metadata on activities and child/scheduled workflows
closes #1673