Add support for unit testing child workflows that call continue-as-new #1437
+70
−79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
Apr 9, 2024
|
Will let @Quinn-With-Two-Ns review to see if he spots anything |
Quinn-With-Two-Ns
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added support for unit testing child workflows that call continue-as-new.
The change is safe as it wasn't possible to test such scenarios.
Why?
The unit testing framework doesn't support tests that include child workflows that call continue-as-new.
Checklist
Closes It is not possible to unit test a child workflow that calls continue as new. #1435
How was this tested:
Added Test_ChildWorkflow_ContinueAsNew unit test.