New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update webpack #2868
Update webpack #2868
Conversation
/test pull-tekton-dashboard-integration-tests |
1 similar comment
/test pull-tekton-dashboard-integration-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
E2E failure appears to be genuine, also happening on #2870 (dependabot PR to update webpack)
Not reproduced locally in dev mode, testing production build now. |
Reproduced locally with production webpack build. It's a known issue with the latest webpack release: webpack/webpack#17042 This breaks our loading of the translations: dashboard/src/containers/App/App.js Lines 119 to 120 in 488c2c8
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: briangleeson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test tekton-dashboard-unit-tests |
Changes
/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes