Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webpack #2868

Merged
merged 1 commit into from Apr 27, 2023
Merged

Update webpack #2868

merged 1 commit into from Apr 27, 2023

Conversation

AlanGreene
Copy link
Member

Changes

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (new features, significant UI changes, API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added kind/misc Categorizes issue or PR as a miscellaneuous one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 21, 2023
@AlanGreene
Copy link
Member Author

/test pull-tekton-dashboard-integration-tests

1 similar comment
@AlanGreene
Copy link
Member Author

/test pull-tekton-dashboard-integration-tests

Copy link
Contributor

@briangleeson briangleeson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 24, 2023
@AlanGreene
Copy link
Member Author

E2E failure appears to be genuine, also happening on #2870 (dependabot PR to update webpack)

  1) Translations
       should display translated content for a supported language:
     AssertionError: Timed out retrying after 4000ms: Expected to find content: '关于' within the selector: 'h1' but never did.
      at Context.eval (webpack:///./cypress/e2e/common/i18n.cy.js:24:7)

Not reproduced locally in dev mode, testing production build now.

@AlanGreene
Copy link
Member Author

Reproduced locally with production webpack build. It's a known issue with the latest webpack release: webpack/webpack#17042

This breaks our loading of the translations:

const { default: loadedMessages } = await import(
/* webpackChunkName: "[request]" */ `../../nls/messages_${targetLocale}.json`

@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 27, 2023
Copy link
Contributor

@briangleeson briangleeson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 27, 2023
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: briangleeson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@AlanGreene
Copy link
Member Author

/test tekton-dashboard-unit-tests

@tekton-robot tekton-robot merged commit a5ca0b2 into tektoncd:main Apr 27, 2023
8 checks passed
@AlanGreene AlanGreene deleted the webpack branch April 27, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants