Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msnodesqlv8 Detailed Errors #1212

Merged
merged 3 commits into from
Apr 15, 2021
Merged

msnodesqlv8 Detailed Errors #1212

merged 3 commits into from
Apr 15, 2021

Conversation

mtriff
Copy link
Contributor

@mtriff mtriff commented Apr 8, 2021

What this does:
As of v2.0.13, msnodesqlv8 now supports detailed errors, see TimelordUK/node-sqlserver-v8#202.
I've added support to mssql for the detailed errors as well.

I've also update the README as both known issues with msnodesqlv8 appear to be resolved.

@mtriff
Copy link
Contributor Author

mtriff commented Apr 9, 2021

I see that the AppVeyor tests failed due to the 6 branch still targeting msnodesqlv8^1.1 (all the tests run clean for me locally with the latest version of msnodesqlv8).

Should I submit a new PR with these changes based on master?

@dhensby
Copy link
Collaborator

dhensby commented Apr 14, 2021

Should I submit a new PR with these changes based on master?

You don't need a new PR, just to rebase your work against master and to change the target branch of this PR (using the edit button). v6 of this lib is linked to v1 of msnodesql and master (v7) against v2 of msnodesql.

mtriff added 2 commits April 14, 2021 18:12

Verified

This commit was signed with the committer’s verified signature.
zemyblue zemyblue
@mtriff mtriff changed the base branch from 6 to master April 14, 2021 22:19
@mtriff
Copy link
Contributor Author

mtriff commented Apr 14, 2021

Thanks! I've made the changes.

Any ETA or blockers for the official 7.0 release? No pressure 😃.

@dhensby dhensby merged commit 9d0105e into tediousjs:master Apr 15, 2021
@dhensby
Copy link
Collaborator

dhensby commented Apr 15, 2021

Any ETA or blockers for the official 7.0 release? No pressure 😃.

Good question; I think we're really close, actually. I'm currently using it in prod for a project so want to keep an eye on it for a bit. I'll release what we have so far as a beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants