Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typehints for getHeaderMargin() and setHeaderMargin() are inconsistent #598

Merged
merged 3 commits into from
Sep 6, 2023
Merged

Typehints for getHeaderMargin() and setHeaderMargin() are inconsistent #598

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d702e33
Typehints for get/setHeaderMargin are inconstent
fisharebest Mar 19, 2023
7d76401
Add typehints for header/footer margin properties
fisharebest Mar 19, 2023
1499838
Merge branch 'main' into main
nicolaasuni Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions tcpdf.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -574,12 +574,14 @@ class TCPDF {
/**
* Minimum distance between header and top page margin.
* @protected
* @var float
*/
protected $header_margin;

/**
* Minimum distance between footer and bottom page margin.
* @protected
* @var float
*/
protected $footer_margin;

Expand Down Expand Up @@ -3372,7 +3374,7 @@ public function getHeaderData() {
/**
* Set header margin.
* (minimum distance between header and top page margin)
* @param int $hm distance in user units
* @param float $hm distance in user units
* @public
*/
public function setHeaderMargin($hm=10) {
Expand All @@ -3392,7 +3394,7 @@ public function getHeaderMargin() {
/**
* Set footer margin.
* (minimum distance between footer and bottom page margin)
* @param int $fm distance in user units
* @param float $fm distance in user units
* @public
*/
public function setFooterMargin($fm=10) {
Expand Down