Typehints for getHeaderMargin() and setHeaderMargin() are inconsistent #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #598 +/- ##
=======================================
Coverage 69.33% 69.33%
=======================================
Files 128 128
Lines 27022 27022
=======================================
Hits 18735 18735
Misses 8287 8287
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
williamdes
previously approved these changes
Mar 19, 2023
Sure! I wasn't sure of the project's policy - so I just changed the external interfaces. |
fisharebest
changed the title
williamdes
approved these changes
Mar 19, 2023
Closed
nicolaasuni
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just updates a couple of inconsistent type-hints in the phpdoc.
The header/footer margins are both
float, but the getters/setters have inconsistent PHPDOC.getFooterMargin()has@return float, butsetFooterMargin()has@param int $fm.getHeaderMargin()has@return float, butsetHeaderMargin()has@param int $hm.