Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hyper role, to render hyperlinks with style #71

Merged
merged 4 commits into from
Apr 6, 2024
Merged

Add hyper role, to render hyperlinks with style #71

merged 4 commits into from
Apr 6, 2024

Conversation

amotl
Copy link
Contributor

@amotl amotl commented Mar 25, 2024

About

An element to render hyperlinks, based on foundational components coming from sphinx{design}. It implements the Sphinx role hyper.

Preview

https://sphinx-design-elements--71.org.readthedocs.build/en/71/hyper.html

Details

Usage

Markdown

{hyper}`https://example.org`

reStructuredText

:hyper:`https://example.org`

References

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 94.48622% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 94.71%. Comparing base (c675d47) to head (1169e80).
Report is 1 commits behind head on main.

❗ Current head 1169e80 differs from pull request most recent head aa7cc59. Consider uploading reports for the commit aa7cc59 to get more accurate results

Files Patch % Lines
sphinx_design_elements/hyper.py 96.01% 9 Missing ⚠️
sphinx_design_elements/util/role.py 83.67% 8 Missing ⚠️
sphinx_design_elements/shield.py 91.52% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
- Coverage   95.21%   94.71%   -0.50%     
==========================================
  Files           6       10       +4     
  Lines         188      587     +399     
==========================================
+ Hits          179      556     +377     
- Misses          9       31      +22     
Flag Coverage Δ
unittests 94.71% <94.48%> (-0.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amotl amotl force-pushed the hyper branch 4 times, most recently from 19389a0 to da5b9a6 Compare March 26, 2024 20:25
@amotl amotl changed the title Add hyper role, to render hyperlinks, optionally using badge shields Add hyper role, to render hyperlinks with bells and whistles Mar 26, 2024
@amotl amotl marked this pull request as ready for review March 27, 2024 02:41
@amotl
Copy link
Contributor Author

amotl commented Mar 27, 2024

Dear @chrisjsewell,

may we humbly ask you to have a look at this, specifically the syntax extensions of the new hyper role on behalf of its documentation, and convey corresponding feedback if you think this is totally silly or not?

We don't have so many capacities in our community to review Sphinx-related details, that is why we are approaching you about it, also because this machinery significantly builds upon your great work at sphinx-design. ✨

Thank you very much in advance. 🙏

With kind regards,
Andreas.

@amotl amotl changed the title Add hyper role, to render hyperlinks with bells and whistles Add hyper role, to render hyperlinks with style Mar 27, 2024
Base automatically changed from shield to main April 6, 2024 16:12
@amotl amotl merged commit 5689b61 into main Apr 6, 2024
3 checks passed
@amotl amotl deleted the hyper branch April 6, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant