Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spurious dependencies to org.json and git-commit-id-maven plugin. #143

Merged
merged 2 commits into from
Dec 30, 2021

Conversation

wetneb
Copy link
Contributor

@wetneb wetneb commented Dec 30, 2021

Fixes #142.

New dependencies:

[INFO] org.odftoolkit:odfdom-java:jar:0.11.0-SNAPSHOT
[INFO] +- xerces:xercesImpl:jar:2.12.1:compile
[INFO] +- xalan:serializer:jar:2.7.2:compile
[INFO] +- junit:junit:jar:4.13.2:test
[INFO] |  \- org.hamcrest:hamcrest-core:jar:1.3:test
[INFO] +- org.apache.jena:jena-core:jar:4.3.0:compile
[INFO] |  +- org.apache.jena:jena-base:jar:4.3.0:compile
[INFO] |  |  +- org.apache.jena:jena-shaded-guava:jar:4.3.0:compile
[INFO] |  |  +- org.apache.commons:commons-csv:jar:1.9.0:compile
[INFO] |  |  +- commons-io:commons-io:jar:2.11.0:compile
[INFO] |  |  +- commons-codec:commons-codec:jar:1.15:compile
[INFO] |  |  \- com.github.andrewoma.dexx:collection:jar:0.7:compile
[INFO] |  +- org.apache.jena:jena-iri:jar:4.3.0:compile
[INFO] |  \- commons-cli:commons-cli:jar:1.5.0:compile
[INFO] +- org.apache.jena:jena-core:jar:tests:4.3.0:test
[INFO] +- net.rootdev:java-rdfa:jar:1.0.0-BETA1:compile
[INFO] +- commons-validator:commons-validator:jar:1.7:compile
[INFO] |  +- commons-beanutils:commons-beanutils:jar:1.9.4:compile
[INFO] |  +- commons-digester:commons-digester:jar:2.1:compile
[INFO] |  +- commons-logging:commons-logging:jar:1.2:compile
[INFO] |  \- commons-collections:commons-collections:jar:3.2.2:compile
[INFO] +- org.apache.commons:commons-lang3:jar:3.12.0:compile
[INFO] +- org.slf4j:slf4j-api:jar:1.7.32:compile
[INFO] +- org.slf4j:slf4j-simple:jar:1.7.32:compile
[INFO] \- org.apache.commons:commons-compress:jar:1.21:compile

@wetneb
Copy link
Contributor Author

wetneb commented Dec 30, 2021

Aargh, this library actually depends on org.json, that dependency was not spurious. This has a license that is not OSI-compliant. I'll open a separate issue about this.

@wetneb
Copy link
Contributor Author

wetneb commented Dec 30, 2021

Issue about the dependency to org.json: #144

@svanteschubert
Copy link
Contributor

We might change/add
io.github.git-commit-id
to a test dependency.

The reason for this dependency:
During building the current GIT commit hash is being extracted and placed into the manifest to be read out whenever a "java -jar odfdom.jar is being called to be certain when similar behaviour can be expected from ODFDOM JARs.
But yes, this GIT extraction functionality is not required during run-time. Indeed a bug!

@wetneb
Copy link
Contributor Author

wetneb commented Dec 30, 2021

Well, if the tests pass without this dependency, I do not think we need to add this artifact as a test dependency. Maven can use it as part of the build process already, since it is declared as a plugin.

Copy link
Contributor

@svanteschubert svanteschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, Antonin! And many thanks for your quick patch!
Cheers,
Svante

@svanteschubert svanteschubert merged commit 7878c2d into tdf:master Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Many unneeded compile time dependencies declared in pom.xml
2 participants