-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): resolve file names from Android content URIs #13012
Conversation
This PR adds a new Android path plugin function to resolve file names from content URIs. `PathResolver::file_name` was added to expose this API on Rust, and the existing `@tauri-apps/api/path` basename and extname function now leverages it on Android. Closes tauri-apps/plugins-workspace#1775 Tauri core port from tauri-apps/plugins-workspace#2421 Co-authored-by: VulnX
Package Changes Through fd26157There are 12 changes which include tauri with minor, tauri-runtime with minor, tauri-runtime-wry with minor, tauri-utils with minor, tauri-cli with minor, @tauri-apps/cli with minor, @tauri-apps/api with minor, tauri-bundler with minor, tauri-build with minor, tauri-codegen with minor, tauri-macros with minor, tauri-plugin with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
@FabianLars do i need to do anything else here to mark @VulnX as the actual author of this change? I saw you mentioned doing something similar on some other PR :D |
I typically just write them in the Co-authored-by in the commit description (iirc you need to look at one of their commits in the cli to know what to write there). You could in theory make them the main author of this commit but that will break the signature verification because you can't transfer/apply the actual commit across projects afaik. |
Needs to look something like |
cool that's what i did - and that's why it's in the description |
It's missing the email, I think that's required Edit: if you push a commit with that inside we can check before merging |
Co-authored-by: VulnX <62636727+VulnX@users.noreply.github.com>
ok it's working now :D |
Hello...thank you merging it |
This PR adds a new Android path plugin function to resolve file names from content URIs.
PathResolver::file_name
was added to expose this API on Rust, and the existing@tauri-apps/api/path
basename and extname function now leverages it on Android.Closes tauri-apps/plugins-workspace#1775
Tauri core port from tauri-apps/plugins-workspace#2421
Co-authored-by: VulnX 62636727+VulnX@users.noreply.github.com