Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): resolve file names from Android content URIs #13012

Merged
merged 2 commits into from
Mar 18, 2025

Conversation

lucasfernog
Copy link
Member

@lucasfernog lucasfernog commented Mar 17, 2025

This PR adds a new Android path plugin function to resolve file names from content URIs. PathResolver::file_name was added to expose this API on Rust, and the existing @tauri-apps/api/path basename and extname function now leverages it on Android.

Closes tauri-apps/plugins-workspace#1775

Tauri core port from tauri-apps/plugins-workspace#2421

Co-authored-by: VulnX 62636727+VulnX@users.noreply.github.com

Verified

This commit was signed with the committer’s verified signature.
coditva Utkarsh Maheshwari
This PR adds a new Android path plugin function to resolve file names from content URIs. `PathResolver::file_name` was added to expose this API on Rust, and the existing `@tauri-apps/api/path` basename and extname function now leverages it on Android.

Closes tauri-apps/plugins-workspace#1775

Tauri core port from tauri-apps/plugins-workspace#2421

Co-authored-by: VulnX
Copy link
Contributor

Package Changes Through fd26157

There are 12 changes which include tauri with minor, tauri-runtime with minor, tauri-runtime-wry with minor, tauri-utils with minor, tauri-cli with minor, @tauri-apps/cli with minor, @tauri-apps/api with minor, tauri-bundler with minor, tauri-build with minor, tauri-codegen with minor, tauri-macros with minor, tauri-plugin with minor

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
@tauri-apps/api 2.3.0 2.4.0
tauri-utils 2.2.0 2.3.0
tauri-bundler 2.2.4 2.3.0
tauri-runtime 2.4.0 2.5.0
tauri-runtime-wry 2.4.1 2.5.0
tauri-codegen 2.0.5 2.1.0
tauri-macros 2.0.5 2.1.0
tauri-plugin 2.0.5 2.1.0
tauri-build 2.0.6 2.1.0
tauri 2.3.1 2.4.0
@tauri-apps/cli 2.3.1 2.4.0
tauri-cli 2.3.1 2.4.0

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@lucasfernog
Copy link
Member Author

@FabianLars do i need to do anything else here to mark @VulnX as the actual author of this change? I saw you mentioned doing something similar on some other PR :D

@FabianLars
Copy link
Member

I typically just write them in the Co-authored-by in the commit description (iirc you need to look at one of their commits in the cli to know what to write there).

You could in theory make them the main author of this commit but that will break the signature verification because you can't transfer/apply the actual commit across projects afaik.

@FabianLars
Copy link
Member

I typically just write them in the Co-authored-by in the commit description (iirc you need to look at one of their commits in the cli to know what to write there).

Needs to look something like Co-authored-by: FabianLars <github@fabianlars.de> - PR description may work as long as it's part of the commit summary window when you squash merge it.

@lucasfernog
Copy link
Member Author

cool that's what i did - and that's why it's in the description
thanks!

@FabianLars
Copy link
Member

FabianLars commented Mar 17, 2025

It's missing the email, I think that's required

Edit: if you push a commit with that inside we can check before merging

Co-authored-by: VulnX <62636727+VulnX@users.noreply.github.com>
@lucasfernog
Copy link
Member Author

ok it's working now :D

@lucasfernog lucasfernog merged commit bcdd510 into dev Mar 18, 2025
3 checks passed
@lucasfernog lucasfernog deleted the feat/path-filename-android branch March 18, 2025 11:29
@VulnX
Copy link
Contributor

VulnX commented Mar 18, 2025

Hello...thank you merging it
Also since this was my very first PR so I am glad I could contribute something to tauri, and hopefully would continue to do it in the future as well ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔎 In audit
Development

Successfully merging this pull request may close these issues.

[fs] On Android I cannot extract filename returned by open / pick_file(s)
4 participants