Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(windows): ensure APIs exist before using it #12848

Merged
merged 4 commits into from
Feb 28, 2025

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Feb 28, 2025

closes #12847

@amrbashir amrbashir requested a review from a team as a code owner February 28, 2025 09:54
Copy link
Contributor

github-actions bot commented Feb 28, 2025

Package Changes Through 65b9b60

There are 3 changes which include tauri-cli with patch, tauri with patch, tauri-runtime-wry with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
tauri-runtime-wry 2.4.0 2.4.1
tauri 2.3.0 2.3.1
@tauri-apps/cli 2.3.0 2.3.1
tauri-cli 2.3.0 2.3.1

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@Legend-Master
Copy link
Contributor

Since we're at it, should we also use the DPI aware APIs for this as well?

let padded_border = GetSystemMetrics(SM_CXPADDEDBORDER);
let border_x = GetSystemMetrics(SM_CXFRAME) + padded_border;
let border_y = GetSystemMetrics(SM_CYFRAME) + padded_border;

lucasfernog
lucasfernog previously approved these changes Feb 28, 2025
@amrbashir
Copy link
Member Author

@Legend-Master nice catch, I distinctively remember telling myself I should update this, apparently my ADHD got the better of me and forgot.

@amrbashir amrbashir merged commit e103e87 into dev Feb 28, 2025
20 checks passed
@amrbashir amrbashir deleted the fix/use-backward-compatible-apis branch February 28, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔎 In audit
Development

Successfully merging this pull request may close these issues.

[bug] GetDpiForWindow could not be located on Windows <1607
3 participants