Skip to content

Use @tailwindcss/node for import in CLI #17502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025
Merged

Conversation

philipp-spiess
Copy link
Member

@philipp-spiess philipp-spiess commented Apr 2, 2025

Closes #17501

Seems like an oversight. The CLI does have a dependency on @tailwindcss/node so it should use it from the public import like the other stuff.

Test plan

Looked at the minified dist/ output to ensure the import for jiti is gone

@philipp-spiess philipp-spiess requested a review from a team as a code owner April 2, 2025 09:12
@philipp-spiess philipp-spiess enabled auto-merge (squash) April 2, 2025 09:13
Copy link
Member

@RobinMalfait RobinMalfait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running a local build of this branch does fix the problem. 💪

No more "jiti" in the bundle after this change.

Before:
image

After:
image

@philipp-spiess philipp-spiess merged commit a429462 into main Apr 2, 2025
7 checks passed
@philipp-spiess philipp-spiess deleted the fix/cli-node-dep branch April 2, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@tailwindcss/cli@4.1.0 misses jiti dependency
2 participants